From: David Miller <davem@davemloft.net>
To: thompa.atl@gmail.com
Cc: netdev@vger.kernel.org, tipc-discussion@lists.sourceforge.net,
jon.maloy@ericsson.com, ying.xue@windriver.com
Subject: Re: [net-next PATCH 1/1] tipc: add back tipc prefix to log messages
Date: Mon, 15 Jan 2018 13:43:39 -0500 (EST) [thread overview]
Message-ID: <20180115.134339.3259388418166535.davem@davemloft.net> (raw)
In-Reply-To: <20180115.134245.1098835558171997498.davem@davemloft.net>
From: David Miller <davem@davemloft.net>
Date: Mon, 15 Jan 2018 13:42:45 -0500 (EST)
> From: John Thompson <thompa.atl@gmail.com>
> Date: Wed, 10 Jan 2018 08:50:24 +1300
>
>> The tipc prefix to log messages generated by tipc was
>> removed in commit 07f6c4bc0 ("tipc: convert tipc reference
>> table to use generic rhashtable").
>>
>> This is still a useful prefix and so add it back.
>>
>> Acked-by: Jon Maloy <jon.maloy@ericsson.com>
>> Signed-off-by: John Thompson <thompa.atl@gmail.com>
>
> Applied, thank you.
Actually, this breaks the build, reverted:
In file included from net/tipc/addr.h:44:0,
from net/tipc/addr.c:38:
net/tipc/core.h:40:0: warning: "pr_fmt" redefined
#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
In file included from ./include/linux/kernel.h:14:0,
from net/tipc/addr.c:37:
./include/linux/printk.h:285:0: note: this is the location of the previous definition
#define pr_fmt(fmt) fmt
next prev parent reply other threads:[~2018-01-15 18:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-09 19:50 [net-next PATCH 1/1] tipc: add back tipc prefix to log messages John Thompson
2018-01-15 18:42 ` David Miller
2018-01-15 18:43 ` David Miller [this message]
-- strict thread matches above, loose matches on Subject: below --
2017-12-11 21:54 John Thompson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180115.134339.3259388418166535.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=jon.maloy@ericsson.com \
--cc=netdev@vger.kernel.org \
--cc=thompa.atl@gmail.com \
--cc=tipc-discussion@lists.sourceforge.net \
--cc=ying.xue@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).