From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [net-next PATCH 1/1] tipc: add back tipc prefix to log messages Date: Mon, 15 Jan 2018 13:43:39 -0500 (EST) Message-ID: <20180115.134339.3259388418166535.davem@davemloft.net> References: <20180115.134245.1098835558171997498.davem@davemloft.net> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, tipc-discussion@lists.sourceforge.net, jon.maloy@ericsson.com, ying.xue@windriver.com To: thompa.atl@gmail.com Return-path: Received: from shards.monkeyblade.net ([184.105.139.130]:50490 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751028AbeAOSnl (ORCPT ); Mon, 15 Jan 2018 13:43:41 -0500 In-Reply-To: <20180115.134245.1098835558171997498.davem@davemloft.net> Sender: netdev-owner@vger.kernel.org List-ID: From: David Miller Date: Mon, 15 Jan 2018 13:42:45 -0500 (EST) > From: John Thompson > Date: Wed, 10 Jan 2018 08:50:24 +1300 > >> The tipc prefix to log messages generated by tipc was >> removed in commit 07f6c4bc0 ("tipc: convert tipc reference >> table to use generic rhashtable"). >> >> This is still a useful prefix and so add it back. >> >> Acked-by: Jon Maloy >> Signed-off-by: John Thompson > > Applied, thank you. Actually, this breaks the build, reverted: In file included from net/tipc/addr.h:44:0, from net/tipc/addr.c:38: net/tipc/core.h:40:0: warning: "pr_fmt" redefined #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt In file included from ./include/linux/kernel.h:14:0, from net/tipc/addr.c:37: ./include/linux/printk.h:285:0: note: this is the location of the previous definition #define pr_fmt(fmt) fmt