From: David Miller <davem@davemloft.net>
To: jon.maloy@ericsson.com
Cc: netdev@vger.kernel.org, tipc-discussion@lists.sourceforge.net,
hoang.h.le@dektech.com.au,
mohan.krishna.ghanta.krishnamurthy@ericsson.com
Subject: Re: [net-next 1/1] tipc: fix a potental access after delete in tipc_sk_join()
Date: Mon, 15 Jan 2018 13:44:06 -0500 (EST) [thread overview]
Message-ID: <20180115.134406.1797630492013260374.davem@davemloft.net> (raw)
In-Reply-To: <1515614930-9257-1-git-send-email-jon.maloy@ericsson.com>
From: Jon Maloy <jon.maloy@ericsson.com>
Date: Wed, 10 Jan 2018 21:08:50 +0100
> In commit d12d2e12cec2 "tipc: send out join messages as soon as new
> member is discovered") we added a call to the function tipc_group_join()
> without considering the case that the preceding tipc_sk_publish() might
> have failed, and the group item already deleted.
>
> We fix this by returning from tipc_sk_join() directly after the
> failed tipc_sk_publish.
>
> Reported-by: syzbot+e3eeae78ea88b8d6d858@syzkaller.appspotmail.com
> Signed-off-by: Jon Maloy <jon.maloy@ericsson.com>
Applied, thanks Jon.
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
prev parent reply other threads:[~2018-01-15 18:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-10 20:08 [net-next 1/1] tipc: fix a potental access after delete in tipc_sk_join() Jon Maloy
2018-01-15 18:44 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180115.134406.1797630492013260374.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=hoang.h.le@dektech.com.au \
--cc=jon.maloy@ericsson.com \
--cc=mohan.krishna.ghanta.krishnamurthy@ericsson.com \
--cc=netdev@vger.kernel.org \
--cc=tipc-discussion@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).