From: David Miller <davem@davemloft.net>
To: hkallweit1@gmail.com
Cc: andrew@lunn.ch, f.fainelli@gmail.com, opendmb@gmail.com,
netdev@vger.kernel.org
Subject: Re: [PATCH net-next v2] net: phy: remove parameter new_link from phy_mac_interrupt()
Date: Mon, 15 Jan 2018 13:45:22 -0500 (EST) [thread overview]
Message-ID: <20180115.134522.1443386500581434982.davem@davemloft.net> (raw)
In-Reply-To: <265d0b95-874e-5d94-aa4e-3bcf9b2b396d@gmail.com>
From: Heiner Kallweit <hkallweit1@gmail.com>
Date: Wed, 10 Jan 2018 21:21:31 +0100
> I see two issues with parameter new_link:
>
> 1. It's not needed. See also phy_interrupt(), works w/o this parameter.
> phy_mac_interrupt sets the state to PHY_CHANGELINK and triggers the
> state machine which then calls phy_read_status. And phy_read_status
> updates the link state.
>
> 2. phy_mac_interrupt is used in interrupt context and getting the link
> state may sleep (at least when having to access the PHY registers
> via MDIO bus).
>
> So let's remove it.
>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
> ---
> v2:
> - combine both patches to avoid a build failure
Applied, thank you.
prev parent reply other threads:[~2018-01-15 18:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-10 20:21 [PATCH net-next v2] net: phy: remove parameter new_link from phy_mac_interrupt() Heiner Kallweit
2018-01-12 1:20 ` Florian Fainelli
2018-01-15 18:45 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180115.134522.1443386500581434982.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andrew@lunn.ch \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=opendmb@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).