From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [Patch net] tipc: fix a memory leak in tipc_nl_node_get_link() Date: Mon, 15 Jan 2018 13:46:45 -0500 (EST) Message-ID: <20180115.134645.1508556387894986585.davem@davemloft.net> References: <20180110205025.7124-1-xiyou.wangcong@gmail.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, dvyukov@google.com, jon.maloy@ericsson.com, ying.xue@windriver.com To: xiyou.wangcong@gmail.com Return-path: Received: from shards.monkeyblade.net ([184.105.139.130]:50592 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750967AbeAOSqr (ORCPT ); Mon, 15 Jan 2018 13:46:47 -0500 In-Reply-To: <20180110205025.7124-1-xiyou.wangcong@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: From: Cong Wang Date: Wed, 10 Jan 2018 12:50:25 -0800 > When tipc_node_find_by_name() fails, the nlmsg is not > freed. > > While on it, switch to a goto label to properly > free it. > > Fixes: be9c086715c ("tipc: narrow down exposure of struct tipc_node") > Reported-by: Dmitry Vyukov > Cc: Jon Maloy > Cc: Ying Xue > Signed-off-by: Cong Wang Applied, thanks.