From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH] usbnet: silence an unnecessary warning Date: Mon, 15 Jan 2018 13:55:44 -0500 (EST) Message-ID: <20180115.135544.804519768257591458.davem@davemloft.net> References: <20180111150149.32528-1-oneukum@suse.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=iso-8859-1 Content-Transfer-Encoding: 8BIT Cc: netdev@vger.kernel.org To: oneukum@suse.com Return-path: Received: from shards.monkeyblade.net ([184.105.139.130]:50870 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751345AbeAOSzp (ORCPT ); Mon, 15 Jan 2018 13:55:45 -0500 In-Reply-To: <20180111150149.32528-1-oneukum@suse.com> Sender: netdev-owner@vger.kernel.org List-ID: From: Oliver Neukum Date: Thu, 11 Jan 2018 16:01:49 +0100 > That a kevent could not be scheduled is not an error. > Such handlers must be able to deal with multiple events anyway. > As the successful scheduling of a work is a debug event, make > the failure debug priority, too. > > Signed-off-by: Oliver Neukum > Reported-by: Cristian Caravena > --- > drivers/net/usb/usbnet.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/net/usb/usbnet.c b/drivers/net/usb/usbnet.c > index d56fe32bf48d..1e0bbe23f95c 100644 > --- a/drivers/net/usb/usbnet.c > +++ b/drivers/net/usb/usbnet.c > @@ -458,8 +458,7 @@ void usbnet_defer_kevent (struct usbnet *dev, int work) > { > set_bit (work, &dev->flags); > if (!schedule_work (&dev->kevent)) { > - if (net_ratelimit()) > - netdev_err(dev->net, "kevent %d may have been dropped\n", work); > + netdev_dbg(dev->net, "kevent %d may have been dropped\n", work); > } else { > netdev_dbg(dev->net, "kevent %d scheduled\n", work); > } As Bjørn stated, you have to clean up the braces since both arms of the conditional are now a single line and therefore should not get curly braces. Thank you.