* [PATCH net] sctp: removed unused var from sctp_make_auth
@ 2018-01-11 16:22 Marcelo Ricardo Leitner
2018-01-12 20:16 ` Neil Horman
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Marcelo Ricardo Leitner @ 2018-01-11 16:22 UTC (permalink / raw)
To: netdev; +Cc: linux-sctp, Neil Horman, Vlad Yasevich
Signed-off-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
---
net/sctp/sm_make_chunk.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/net/sctp/sm_make_chunk.c b/net/sctp/sm_make_chunk.c
index 9bf575f2e8ed0888e0219a872e84018ada5064e0..f08531de5682256064ce35e3d44200caa71c3db8 100644
--- a/net/sctp/sm_make_chunk.c
+++ b/net/sctp/sm_make_chunk.c
@@ -1273,7 +1273,6 @@ struct sctp_chunk *sctp_make_auth(const struct sctp_association *asoc)
struct sctp_authhdr auth_hdr;
struct sctp_hmac *hmac_desc;
struct sctp_chunk *retval;
- __u8 *hmac;
/* Get the first hmac that the peer told us to use */
hmac_desc = sctp_auth_asoc_get_hmac(asoc);
@@ -1292,7 +1291,7 @@ struct sctp_chunk *sctp_make_auth(const struct sctp_association *asoc)
retval->subh.auth_hdr = sctp_addto_chunk(retval, sizeof(auth_hdr),
&auth_hdr);
- hmac = skb_put_zero(retval->skb, hmac_desc->hmac_len);
+ skb_put_zero(retval->skb, hmac_desc->hmac_len);
/* Adjust the chunk header to include the empty MAC */
retval->chunk_hdr->length =
--
2.14.3
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH net] sctp: removed unused var from sctp_make_auth
2018-01-11 16:22 [PATCH net] sctp: removed unused var from sctp_make_auth Marcelo Ricardo Leitner
@ 2018-01-12 20:16 ` Neil Horman
2018-01-13 4:50 ` Xin Long
2018-01-15 19:00 ` David Miller
2 siblings, 0 replies; 4+ messages in thread
From: Neil Horman @ 2018-01-12 20:16 UTC (permalink / raw)
To: Marcelo Ricardo Leitner; +Cc: netdev, linux-sctp, Vlad Yasevich
On Thu, Jan 11, 2018 at 02:22:07PM -0200, Marcelo Ricardo Leitner wrote:
> Signed-off-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
> ---
> net/sctp/sm_make_chunk.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/net/sctp/sm_make_chunk.c b/net/sctp/sm_make_chunk.c
> index 9bf575f2e8ed0888e0219a872e84018ada5064e0..f08531de5682256064ce35e3d44200caa71c3db8 100644
> --- a/net/sctp/sm_make_chunk.c
> +++ b/net/sctp/sm_make_chunk.c
> @@ -1273,7 +1273,6 @@ struct sctp_chunk *sctp_make_auth(const struct sctp_association *asoc)
> struct sctp_authhdr auth_hdr;
> struct sctp_hmac *hmac_desc;
> struct sctp_chunk *retval;
> - __u8 *hmac;
>
> /* Get the first hmac that the peer told us to use */
> hmac_desc = sctp_auth_asoc_get_hmac(asoc);
> @@ -1292,7 +1291,7 @@ struct sctp_chunk *sctp_make_auth(const struct sctp_association *asoc)
> retval->subh.auth_hdr = sctp_addto_chunk(retval, sizeof(auth_hdr),
> &auth_hdr);
>
> - hmac = skb_put_zero(retval->skb, hmac_desc->hmac_len);
> + skb_put_zero(retval->skb, hmac_desc->hmac_len);
>
> /* Adjust the chunk header to include the empty MAC */
> retval->chunk_hdr->length =
> --
> 2.14.3
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-sctp" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
Acked-by: Neil Horman <nhorman@tuxdriver.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH net] sctp: removed unused var from sctp_make_auth
2018-01-11 16:22 [PATCH net] sctp: removed unused var from sctp_make_auth Marcelo Ricardo Leitner
2018-01-12 20:16 ` Neil Horman
@ 2018-01-13 4:50 ` Xin Long
2018-01-15 19:00 ` David Miller
2 siblings, 0 replies; 4+ messages in thread
From: Xin Long @ 2018-01-13 4:50 UTC (permalink / raw)
To: Marcelo Ricardo Leitner
Cc: network dev, linux-sctp, Neil Horman, Vlad Yasevich
On Fri, Jan 12, 2018 at 12:22 AM, Marcelo Ricardo Leitner
<marcelo.leitner@gmail.com> wrote:
> Signed-off-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
> ---
> net/sctp/sm_make_chunk.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/net/sctp/sm_make_chunk.c b/net/sctp/sm_make_chunk.c
> index 9bf575f2e8ed0888e0219a872e84018ada5064e0..f08531de5682256064ce35e3d44200caa71c3db8 100644
> --- a/net/sctp/sm_make_chunk.c
> +++ b/net/sctp/sm_make_chunk.c
> @@ -1273,7 +1273,6 @@ struct sctp_chunk *sctp_make_auth(const struct sctp_association *asoc)
> struct sctp_authhdr auth_hdr;
> struct sctp_hmac *hmac_desc;
> struct sctp_chunk *retval;
> - __u8 *hmac;
>
> /* Get the first hmac that the peer told us to use */
> hmac_desc = sctp_auth_asoc_get_hmac(asoc);
> @@ -1292,7 +1291,7 @@ struct sctp_chunk *sctp_make_auth(const struct sctp_association *asoc)
> retval->subh.auth_hdr = sctp_addto_chunk(retval, sizeof(auth_hdr),
> &auth_hdr);
>
> - hmac = skb_put_zero(retval->skb, hmac_desc->hmac_len);
> + skb_put_zero(retval->skb, hmac_desc->hmac_len);
>
> /* Adjust the chunk header to include the empty MAC */
> retval->chunk_hdr->length =
> --
> 2.14.3
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-sctp" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
Reviewed-by: Xin Long <lucien.xin@gmail.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH net] sctp: removed unused var from sctp_make_auth
2018-01-11 16:22 [PATCH net] sctp: removed unused var from sctp_make_auth Marcelo Ricardo Leitner
2018-01-12 20:16 ` Neil Horman
2018-01-13 4:50 ` Xin Long
@ 2018-01-15 19:00 ` David Miller
2 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2018-01-15 19:00 UTC (permalink / raw)
To: marcelo.leitner; +Cc: netdev, linux-sctp, nhorman, vyasevich
From: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Date: Thu, 11 Jan 2018 14:22:07 -0200
> Signed-off-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Applied to net-next.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-01-15 19:00 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-01-11 16:22 [PATCH net] sctp: removed unused var from sctp_make_auth Marcelo Ricardo Leitner
2018-01-12 20:16 ` Neil Horman
2018-01-13 4:50 ` Xin Long
2018-01-15 19:00 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).