From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [net-next 1/1] tipc: fix bug during lookup of multicast destination nodes Date: Mon, 15 Jan 2018 14:27:29 -0500 (EST) Message-ID: <20180115.142729.659157027252943827.davem@davemloft.net> References: <1515787010-10082-1-git-send-email-jon.maloy@ericsson.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, tipc-discussion@lists.sourceforge.net, hoang.h.le@dektech.com.au, mohan.krishna.ghanta.krishnamurthy@ericsson.com To: jon.maloy@ericsson.com Return-path: In-Reply-To: <1515787010-10082-1-git-send-email-jon.maloy@ericsson.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: tipc-discussion-bounces@lists.sourceforge.net List-Id: netdev.vger.kernel.org From: Jon Maloy Date: Fri, 12 Jan 2018 20:56:50 +0100 > In commit 232d07b74a33 ("tipc: improve groupcast scope handling") we > inadvertently broke non-group multicast transmission when changing the > parameter 'domain' to 'scope' in the function > tipc_nametbl_lookup_dst_nodes(). We missed to make the corresponding > change in the calling function, with the result that the lookup always > fails. > > A closer anaysis reveals that this parameter is not needed at all. > Non-group multicast is hard coded to use CLUSTER_SCOPE, and in the > current implementation this will be delivered to all matching > destinations except those which are published with NODE_SCOPE on other > nodes. Since such publications never will be visible on the sending node > anyway, it makes no sense to discriminate by scope at all. > > We now remove this parameter altogether. > > Signed-off-by: Jon Maloy Applied, thanks Jon. ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot