From: David Miller <davem@davemloft.net>
To: jwestfall@surrealistic.net
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH v2 0/2] ipv4: Make neigh lookup keys for loopback/point-to-point devices be INADDR_ANY
Date: Mon, 15 Jan 2018 16:59:53 -0500 (EST) [thread overview]
Message-ID: <20180115.165953.1129966159870806622.davem@davemloft.net> (raw)
In-Reply-To: <20180115214238.GA29518@surrealistic.net>
From: Jim Westfall <jwestfall@surrealistic.net>
Date: Mon, 15 Jan 2018 13:42:38 -0800
> David Miller <davem@davemloft.net> wrote [01.15.18]:
>> From: Jim Westfall <jwestfall@surrealistic.net>
>> Date: Sun, 14 Jan 2018 04:18:49 -0800
>>
>> > This used to be the previous behavior in older kernels but became broken in
>> > a263b3093641f (ipv4: Make neigh lookups directly in output packet path)
>> > and then later removed because it was broken in 0bb4087cbec0 (ipv4: Fix neigh
>> > lookup keying over loopback/point-to-point devices)
>> >
>> > Not having this results in there being an arp entry for every remote ip
>> > address that the device talks to. Given a fairly active device it can
>> > cause the arp table to become huge and/or having to add/purge large number
>> > of entires to keep within table size thresholds.
>> ...
>> > v2:
>> > - fixes coding style issues
>>
>> Series applied and queued up for -stable, thank you.
>
> Thanks for applying these. We see the same type of behavior with ipv6
> over point-to-point interfaces and I would like to fix these as well by
> mapping all the ndisc_cache entries to in6addr_any. However my knowledge
> of ndisc is limited and I'm unclear if its safe to assume ndisc, like
> arp, would never exist on the point-to-point interface.
Ok, hopefully some ipv6 experts can chime in.
Thank you.
prev parent reply other threads:[~2018-01-15 21:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-14 12:18 [PATCH v2 0/2] ipv4: Make neigh lookup keys for loopback/point-to-point devices be INADDR_ANY Jim Westfall
2018-01-14 12:18 ` [PATCH v2 1/2] net: Allow neigh contructor functions ability to modify the primary_key Jim Westfall
2018-01-14 12:18 ` [PATCH v2 2/2] ipv4: Make neigh lookup keys for loopback/point-to-point devices be INADDR_ANY Jim Westfall
2018-01-15 19:54 ` [PATCH v2 0/2] " David Miller
2018-01-15 21:42 ` Jim Westfall
2018-01-15 21:59 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180115.165953.1129966159870806622.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=jwestfall@surrealistic.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).