From: Stephen Hemminger <stephen@networkplumber.org>
To: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Cc: Daniel Axtens <dja@axtens.net>,
netdev@vger.kernel.org,
Thomas Falcon <tlfalcon@linux.vnet.ibm.com>,
Yuval Mintz <Yuval.Mintz@cavium.com>
Subject: Re: [PATCH v2] bnx2x: disable GSO where gso_size is too big for hardware
Date: Mon, 15 Jan 2018 11:44:02 -0800 [thread overview]
Message-ID: <20180115114402.46090d88@xeon-e3> (raw)
In-Reply-To: <20180112115323.GA19162@localhost.localdomain>
On Fri, 12 Jan 2018 09:53:23 -0200
Marcelo Ricardo Leitner <marcelo.leitner@gmail.com> wrote:
> On Fri, Jan 12, 2018 at 09:48:44AM -0200, Marcelo Ricardo Leitner wrote:
> > On Fri, Jan 12, 2018 at 10:59:05AM +1100, Daniel Axtens wrote:
> > > If a bnx2x card is passed a GSO packet with a gso_size larger than
> > > ~9700 bytes, it will cause a firmware error that will bring the card
> > > down:
> >
> > Why not use netif_set_gso_max_size() instead?
> > Some drivers are using it to avoid such larger than supported packets.
>
> Scratch that, sorry. It doesn't take effect in forwarding path.
>
> Marcelo
It still makes sense to tell TCP not to generate huge GSO packets.
For the forwarding path, there needs to be some software recovery
logic in net transmit path.
next prev parent reply other threads:[~2018-01-15 19:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-11 23:59 [PATCH v2] bnx2x: disable GSO where gso_size is too big for hardware Daniel Axtens
2018-01-12 11:48 ` Marcelo Ricardo Leitner
2018-01-12 11:53 ` Marcelo Ricardo Leitner
2018-01-15 19:44 ` Stephen Hemminger [this message]
2018-01-15 14:58 ` Chopra, Manish
2018-01-15 19:06 ` David Miller
2018-01-16 0:12 ` Daniel Axtens
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180115114402.46090d88@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=Yuval.Mintz@cavium.com \
--cc=dja@axtens.net \
--cc=marcelo.leitner@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=tlfalcon@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).