From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH v2] bnx2x: disable GSO where gso_size is too big for hardware Date: Mon, 15 Jan 2018 11:44:02 -0800 Message-ID: <20180115114402.46090d88@xeon-e3> References: <20180111235905.10110-1-dja@axtens.net> <20180112114844.GN725@localhost.localdomain> <20180112115323.GA19162@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: Daniel Axtens , netdev@vger.kernel.org, Thomas Falcon , Yuval Mintz To: Marcelo Ricardo Leitner Return-path: Received: from mail-pl0-f44.google.com ([209.85.160.44]:33780 "EHLO mail-pl0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750704AbeAOToG (ORCPT ); Mon, 15 Jan 2018 14:44:06 -0500 Received: by mail-pl0-f44.google.com with SMTP id t4so1608761plo.0 for ; Mon, 15 Jan 2018 11:44:06 -0800 (PST) In-Reply-To: <20180112115323.GA19162@localhost.localdomain> Sender: netdev-owner@vger.kernel.org List-ID: On Fri, 12 Jan 2018 09:53:23 -0200 Marcelo Ricardo Leitner wrote: > On Fri, Jan 12, 2018 at 09:48:44AM -0200, Marcelo Ricardo Leitner wrote: > > On Fri, Jan 12, 2018 at 10:59:05AM +1100, Daniel Axtens wrote: > > > If a bnx2x card is passed a GSO packet with a gso_size larger than > > > ~9700 bytes, it will cause a firmware error that will bring the card > > > down: > > > > Why not use netif_set_gso_max_size() instead? > > Some drivers are using it to avoid such larger than supported packets. > > Scratch that, sorry. It doesn't take effect in forwarding path. > > Marcelo It still makes sense to tell TCP not to generate huge GSO packets. For the forwarding path, there needs to be some software recovery logic in net transmit path.