From: Christoph Hellwig <hch@infradead.org>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Christoph Hellwig <hch@lst.de>,
Bjorn Helgaas <bhelgaas@google.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Kong Lai <kong.lai@tundra.com>,
linux-pci@vger.kernel.org,
Linux Media Mailing List <linux-media@vger.kernel.org>,
netdev <netdev@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 3/4] tsi108_eth: use dma API properly
Date: Mon, 15 Jan 2018 07:11:48 -0800 [thread overview]
Message-ID: <20180115151148.GA7317@infradead.org> (raw)
In-Reply-To: <CAHp75VeyM+ctSPO5p3DGizR34woFn3=B+b0Uf+pxM5oXkbS=Zw@mail.gmail.com>
On Wed, Jan 10, 2018 at 10:09:20PM +0200, Andy Shevchenko wrote:
> > + struct platform_device *pdev;
>
> Do you really need platform_defice reference?
>
> Perhaps
>
> struct device *hdev; // hardware device
>
>
> data->hdev = &pdev->dev;
>
> Another idea
>
> dev->dev.parent = &pdev->dev;
>
> No new member needed.
Maybe. But what I've done is the simplest change in a long obsolete
driver that I don't understand at all. I'd rather keep it simple.
next prev parent reply other threads:[~2018-01-15 15:11 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-10 18:03 remove pci_dma_* abuses and workarounds V2 Christoph Hellwig
2018-01-10 18:03 ` [PATCH 1/4] media/ttusb-budget: remove pci_zalloc_coherent abuse Christoph Hellwig
2018-01-10 18:03 ` [PATCH 2/4] media/ttusb-dev: " Christoph Hellwig
2018-01-10 18:03 ` [PATCH 3/4] tsi108_eth: use dma API properly Christoph Hellwig
2018-01-10 20:09 ` Andy Shevchenko
2018-01-15 15:11 ` Christoph Hellwig [this message]
2018-01-18 0:08 ` Bjorn Helgaas
2018-01-18 14:11 ` David Miller
2018-01-10 18:03 ` [PATCH 4/4] PCI: Remove NULL device handling from PCI DMA API Christoph Hellwig
2018-01-18 0:08 ` remove pci_dma_* abuses and workarounds V2 Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180115151148.GA7317@infradead.org \
--to=hch@infradead.org \
--cc=andy.shevchenko@gmail.com \
--cc=bhelgaas@google.com \
--cc=hch@lst.de \
--cc=kong.lai@tundra.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).