From: Alexey Dobriyan <adobriyan@gmail.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] net: delete /proc THIS_MODULE references
Date: Mon, 15 Jan 2018 23:40:53 +0300 [thread overview]
Message-ID: <20180115204053.GB6942@avx2> (raw)
In-Reply-To: <20180115.145012.1807423040561212598.davem@davemloft.net>
On Mon, Jan 15, 2018 at 02:50:12PM -0500, David Miller wrote:
> From: Alexey Dobriyan <adobriyan@gmail.com>
> Date: Sat, 13 Jan 2018 20:11:52 +0300
>
> > /proc has been ignoring struct file_operations::owner field for ages.
> >
> > Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
>
> What, then, makes sure that the procfs files are unregistered before the
> referencing module is unloaded?
Core /proc code does the magic just like core net code deletes
interfaces correctly if ethernet modules gets deleted. Most fs/proc/inode.c
is dedicated to this.
> Please explain the situation, and add a reference to the commit that
> made procfs stop using the fops owner field. That commit and it's
> commit message may help explain why all of this is fine.
Sure. It was ~10 years ago :^)
next prev parent reply other threads:[~2018-01-15 20:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-13 17:11 [PATCH] net: delete /proc THIS_MODULE references Alexey Dobriyan
2018-01-15 19:50 ` David Miller
2018-01-15 20:40 ` Alexey Dobriyan [this message]
2018-01-15 23:01 ` Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180115204053.GB6942@avx2 \
--to=adobriyan@gmail.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).