From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net] ibmvnic: Fix pending MAC address changes Date: Tue, 16 Jan 2018 11:26:33 -0500 (EST) Message-ID: <20180116.112633.2177995465153594050.davem@davemloft.net> References: <1515634792-27699-1-git-send-email-tlfalcon@linux.vnet.ibm.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, nfont@linux.vnet.ibm.com, jallen@linux.vnet.ibm.com To: tlfalcon@linux.vnet.ibm.com Return-path: Received: from shards.monkeyblade.net ([184.105.139.130]:53286 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750911AbeAPQ0h (ORCPT ); Tue, 16 Jan 2018 11:26:37 -0500 In-Reply-To: <1515634792-27699-1-git-send-email-tlfalcon@linux.vnet.ibm.com> Sender: netdev-owner@vger.kernel.org List-ID: From: Thomas Falcon Date: Wed, 10 Jan 2018 19:39:52 -0600 > Due to architecture limitations, the IBM VNIC client driver is unable > to perform MAC address changes unless the device has "logged in" to > its backing device. Currently, pending MAC changes are handled before > login, resulting in an error and failure to change the MAC address. > Moving that chunk to the end of the ibmvnic_login function, when we are > sure that it was successful, fixes that. > > The MAC address can be changed when the device is up or down, so > only check if the device is in a "PROBED" state before setting the > MAC address. > > Fixes: c26eba03e407 ("ibmvnic: Update reset infrastructure to support tunable parameters") > Signed-off-by: Thomas Falcon Applied, thanks.