From: David Miller <davem@davemloft.net>
To: alexey.kodanev@oracle.com
Cc: netdev@vger.kernel.org, tom@herbertland.com
Subject: Re: [PATCH net] ip6_gre: init dev->mtu and dev->hard_header_len correctly
Date: Tue, 16 Jan 2018 11:32:14 -0500 (EST) [thread overview]
Message-ID: <20180116.113214.1563871996543889759.davem@davemloft.net> (raw)
In-Reply-To: <1515675774-1301-1-git-send-email-alexey.kodanev@oracle.com>
From: Alexey Kodanev <alexey.kodanev@oracle.com>
Date: Thu, 11 Jan 2018 16:02:54 +0300
> For ip6gretap, reset dev->mtu to zero in ip6gre_tap_setup()
> after ether_setup(), in order for it to work with the new check
> in ip6gre_tunnel_init_common().
This part is error prone. Please instead add a new boolean argument
to ip6gre_tunnel_init_common: "bool set_mtu". Set it to true when
it is invoked from ip6gre_tap_init() and false when it is invoked
from ip6gre_tunnel_init().
Thank you.
next prev parent reply other threads:[~2018-01-16 16:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-11 13:02 [PATCH net] ip6_gre: init dev->mtu and dev->hard_header_len correctly Alexey Kodanev
2018-01-16 16:32 ` David Miller [this message]
2018-01-17 12:51 ` Alexey Kodanev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180116.113214.1563871996543889759.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=alexey.kodanev@oracle.com \
--cc=netdev@vger.kernel.org \
--cc=tom@herbertland.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).