From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Miller <davem@davemloft.net>
Subject: Re: [PATCH net] ip6_gre: init dev->mtu and dev->hard_header_len
 correctly
Date: Tue, 16 Jan 2018 11:32:14 -0500 (EST)
Message-ID: <20180116.113214.1563871996543889759.davem@davemloft.net>
References: <1515675774-1301-1-git-send-email-alexey.kodanev@oracle.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Cc: netdev@vger.kernel.org, tom@herbertland.com
To: alexey.kodanev@oracle.com
Return-path: <netdev-owner@vger.kernel.org>
Received: from shards.monkeyblade.net ([184.105.139.130]:53502 "EHLO
        shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1750941AbeAPQcP (ORCPT
        <rfc822;netdev@vger.kernel.org>); Tue, 16 Jan 2018 11:32:15 -0500
In-Reply-To: <1515675774-1301-1-git-send-email-alexey.kodanev@oracle.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

From: Alexey Kodanev <alexey.kodanev@oracle.com>
Date: Thu, 11 Jan 2018 16:02:54 +0300

> For ip6gretap, reset dev->mtu to zero in ip6gre_tap_setup()
> after ether_setup(), in order for it to work with the new check
> in ip6gre_tunnel_init_common().

This part is error prone.  Please instead add a new boolean argument
to ip6gre_tunnel_init_common: "bool set_mtu".  Set it to true when
it is invoked from ip6gre_tap_init() and false when it is invoked
from ip6gre_tunnel_init().

Thank you.