From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net] nfp: use the correct index for link speed table Date: Tue, 16 Jan 2018 14:56:04 -0500 (EST) Message-ID: <20180116.145604.917240834254024965.davem@davemloft.net> References: <20180115194753.21336-1-jakub.kicinski@netronome.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, oss-drivers@netronome.com To: jakub.kicinski@netronome.com Return-path: Received: from shards.monkeyblade.net ([184.105.139.130]:59060 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751505AbeAPT4G (ORCPT ); Tue, 16 Jan 2018 14:56:06 -0500 In-Reply-To: <20180115194753.21336-1-jakub.kicinski@netronome.com> Sender: netdev-owner@vger.kernel.org List-ID: From: Jakub Kicinski Date: Mon, 15 Jan 2018 11:47:53 -0800 > sts variable is holding link speed as well as state. We should > be using ls to index into ls_to_ethtool. > > Fixes: 265aeb511bd5 ("nfp: add support for .get_link_ksettings()") > Signed-off-by: Jakub Kicinski Applied and queued up for -stable.