From: David Miller <davem@davemloft.net>
To: roland@kernel.org
Cc: Ariel.Elior@cavium.com, everest-linux-l2@cavium.com,
netdev@vger.kernel.org
Subject: Re: [PATCH] qed: Fix potential use-after-free in qed_spq_post()
Date: Tue, 16 Jan 2018 14:57:52 -0500 (EST) [thread overview]
Message-ID: <20180116.145752.1483453106774774130.davem@davemloft.net> (raw)
In-Reply-To: <20180115202449.14830-1-roland@kernel.org>
From: Roland Dreier <roland@kernel.org>
Date: Mon, 15 Jan 2018 12:24:49 -0800
> From: Roland Dreier <roland@purestorage.com>
>
> We need to check if p_ent->comp_mode is QED_SPQ_MODE_EBLOCK before
> calling qed_spq_add_entry(). The test is fine is the mode is EBLOCK,
> but if it isn't then qed_spq_add_entry() might kfree(p_ent).
>
> Signed-off-by: Roland Dreier <roland@purestorage.com>
Applied, thanks Roland.
prev parent reply other threads:[~2018-01-16 19:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-15 20:24 [PATCH] qed: Fix potential use-after-free in qed_spq_post() Roland Dreier
2018-01-16 19:57 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180116.145752.1483453106774774130.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Ariel.Elior@cavium.com \
--cc=everest-linux-l2@cavium.com \
--cc=netdev@vger.kernel.org \
--cc=roland@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).