From: David Miller <davem@davemloft.net>
To: andrew@lunn.ch
Cc: netdev@vger.kernel.org, vivien.didelot@savoirfairelinux.com
Subject: Re: [PATCH net-next 0/2] ATU and VTU irq fixes
Date: Tue, 16 Jan 2018 15:23:05 -0500 (EST) [thread overview]
Message-ID: <20180116.152305.354782782893397440.davem@davemloft.net> (raw)
In-Reply-To: <20180116.151833.246398991315034718.davem@davemloft.net>
From: David Miller <davem@davemloft.net>
Date: Tue, 16 Jan 2018 15:18:33 -0500 (EST)
> From: Andrew Lunn <andrew@lunn.ch>
> Date: Mon, 15 Jan 2018 23:45:56 +0100
>
>> Further testing and core review found two sets of bugs.
>>
>> Core review found a cut/paste error in the irq setup code.
>>
>> A board which does not have an interrupt line from the switch to the
>> SoC, and experiancing an EPROBE_DEFER throw a splat when the ATU irq
>> was freed but never registered.
>
> Series applied, thanks Andrew.
Uhhh, this breaks the build. Reverting...
drivers/net/dsa/mv88e6xxx/global1_vtu.c: In function ‘mv88e6xxx_g1_vtu_prob_irq_setup’:
drivers/net/dsa/mv88e6xxx/global1_vtu.c:573:14: error: ‘struct mv88e6xxx_chip’ has no member named ‘chip’
return chip->chip->vtu_prob_irq;
prev parent reply other threads:[~2018-01-16 20:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-15 22:45 [PATCH net-next 0/2] ATU and VTU irq fixes Andrew Lunn
2018-01-15 22:45 ` [PATCH net-next 1/2] net: dsa: mv88e6xxx: Return error from irq_find_mapping() Andrew Lunn
2018-01-15 22:45 ` [PATCH net-next 2/2] net: dsa: mv88e6xxx: Free ATU/VTU irq only when there is chip irq Andrew Lunn
2018-01-15 22:54 ` Florian Fainelli
2018-01-15 23:02 ` Andrew Lunn
2018-01-16 20:18 ` [PATCH net-next 0/2] ATU and VTU irq fixes David Miller
2018-01-16 20:23 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180116.152305.354782782893397440.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andrew@lunn.ch \
--cc=netdev@vger.kernel.org \
--cc=vivien.didelot@savoirfairelinux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).