From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH] bnxt_en: don't update cpr->rx_bytes with uninitialized length len Date: Tue, 16 Jan 2018 15:24:53 -0500 (EST) Message-ID: <20180116.152453.1072329036192883739.davem@davemloft.net> References: <20180116102250.22914-1-colin.king@canonical.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: michael.chan@broadcom.com, netdev@vger.kernel.org, andrew.gospodarek@broadcom.com, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org To: colin.king@canonical.com Return-path: In-Reply-To: <20180116102250.22914-1-colin.king@canonical.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org From: Colin King Date: Tue, 16 Jan 2018 10:22:50 +0000 > From: Colin Ian King > > Currently in the cases where cmp_type == CMP_TYPE_RX_L2_TPA_START_CMP or > CMP_TYPE_RX_L2_TPA_END_CMP the exit path updates cpr->rx_bytes with an > uninitialized length len. Fix this by adding a new exit path that does > not update the cpr stats with the bogus length len and remove the unused > label next_rx_no_prod. > > Detected by CoverityScan, CID#1463807 ("Uninitialized scalar variable") > Fixes: 6a8788f25625 ("bnxt_en: add support for software dynamic interrupt moderation") > Signed-off-by: Colin Ian King Applied, thanks.