From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jiri Pirko Subject: Re: [PATCH bpf-next v2 02/11] net: sched: prepare extack support for offload via tc_cls_common_offload Date: Tue, 16 Jan 2018 10:33:52 +0100 Message-ID: <20180116093352.GA2477@nanopsycho> References: <20180116020845.3496-1-jakub.kicinski@netronome.com> <20180116020845.3496-3-jakub.kicinski@netronome.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: davem@davemloft.net, daniel@iogearbox.net, alexei.starovoitov@gmail.com, netdev@vger.kernel.org, dsahern@gmail.com, oss-drivers@netronome.com, john.fastabend@gmail.com, jhs@mojatatu.com, gerlitz.or@gmail.com, aring@mojatatu.com, xiyou.wangcong@gmail.com, Quentin Monnet To: Jakub Kicinski Return-path: Received: from mail-wr0-f194.google.com ([209.85.128.194]:34625 "EHLO mail-wr0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750716AbeAPJdz (ORCPT ); Tue, 16 Jan 2018 04:33:55 -0500 Received: by mail-wr0-f194.google.com with SMTP id 36so14501896wrh.1 for ; Tue, 16 Jan 2018 01:33:54 -0800 (PST) Content-Disposition: inline In-Reply-To: <20180116020845.3496-3-jakub.kicinski@netronome.com> Sender: netdev-owner@vger.kernel.org List-ID: Tue, Jan 16, 2018 at 03:08:36AM CET, jakub.kicinski@netronome.com wrote: >From: Quentin Monnet > >Prepare for extack support for hardware offload of classifiers. In order >to achieve this, a pointer to a struct netlink_ext_ack is added to the >struct tc_cls_common_offload that is passed to the callback for setting >up the classifier. Function tc_cls_common_offload_init() is updated to >support initialization of this new attribute. > >Extack plumbing is not complete yet. > >Signed-off-by: Quentin Monnet >Reviewed-by: Jakub Kicinski >--- [...] >diff --git a/net/sched/cls_flower.c b/net/sched/cls_flower.c >index 998ee4faf934..f1640a98a3d2 100644 >--- a/net/sched/cls_flower.c >+++ b/net/sched/cls_flower.c >@@ -223,7 +223,7 @@ static void fl_hw_destroy_filter(struct tcf_proto *tp, struct cls_fl_filter *f) > struct tc_cls_flower_offload cls_flower = {}; > struct tcf_block *block = tp->chain->block; > >- tc_cls_common_offload_init(&cls_flower.common, tp); >+ tc_cls_common_offload_init(&cls_flower.common, tp, NULL); You should have the patch assing extack arg to fl_hw_replace_filter prior to this patch. Then you don't need this odd NULL pass. Same for other cls.