From: Jiri Pirko <jiri@resnulli.us>
To: Jakub Kicinski <jakub.kicinski@netronome.com>
Cc: davem@davemloft.net, daniel@iogearbox.net,
alexei.starovoitov@gmail.com, netdev@vger.kernel.org,
dsahern@gmail.com, oss-drivers@netronome.com,
john.fastabend@gmail.com, jhs@mojatatu.com, gerlitz.or@gmail.com,
aring@mojatatu.com, xiyou.wangcong@gmail.com,
Quentin Monnet <quentin.monnet@netronome.com>
Subject: Re: [PATCH bpf-next v2 09/11] nfp: bpf: use extack support to improve debugging
Date: Tue, 16 Jan 2018 10:36:01 +0100 [thread overview]
Message-ID: <20180116093601.GB2477@nanopsycho> (raw)
In-Reply-To: <20180116020845.3496-10-jakub.kicinski@netronome.com>
Tue, Jan 16, 2018 at 03:08:43AM CET, jakub.kicinski@netronome.com wrote:
>From: Quentin Monnet <quentin.monnet@netronome.com>
>
>Use the recently added extack support for eBPF offload in the driver.
>
>Signed-off-by: Quentin Monnet <quentin.monnet@netronome.com>
>Reviewed-by: Jakub Kicinski <jakub.kicinski@netronome.com>
>---
[...]
>@@ -303,7 +305,8 @@ static int nfp_net_bpf_load(struct nfp_net *nn, struct bpf_prog *prog)
> /* Load up the JITed code */
> err = nfp_net_reconfig(nn, NFP_NET_CFG_UPDATE_BPF);
> if (err)
>- nn_err(nn, "FW command error while loading BPF: %d\n", err);
>+ NL_SET_ERR_MSG_MOD(extack,
>+ "FW command error while loading BPF");
One line please. Same for all others. Strings may overflow 80 cols.
next prev parent reply other threads:[~2018-01-16 9:36 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-16 2:08 [PATCH bpf-next v2 00/11] net: sched: add extack support for cls offload Jakub Kicinski
2018-01-16 2:08 ` [PATCH bpf-next v2 01/11] net: sched: add extack support to change() classifier operation Jakub Kicinski
2018-01-16 2:08 ` [PATCH bpf-next v2 02/11] net: sched: prepare extack support for offload via tc_cls_common_offload Jakub Kicinski
2018-01-16 9:33 ` Jiri Pirko
2018-01-16 13:08 ` Quentin Monnet
2018-01-16 2:08 ` [PATCH bpf-next v2 03/11] net: sched: cls_flower: propagate extack support for filter offload Jakub Kicinski
2018-01-16 2:08 ` [PATCH bpf-next v2 04/11] net: sched: cls_matchall: " Jakub Kicinski
2018-01-16 2:08 ` [PATCH bpf-next v2 05/11] net: sched: cls_u32: " Jakub Kicinski
2018-01-16 2:08 ` [PATCH bpf-next v2 06/11] net: sched: cls_bpf: plumb extack support in filter for hardware offload Jakub Kicinski
2018-01-16 2:08 ` [PATCH bpf-next v2 07/11] net: sched: create tc_can_offload_extack() wrapper Jakub Kicinski
2018-01-16 2:08 ` [PATCH bpf-next v2 08/11] nfp: bpf: plumb extack into functions related to XDP offload Jakub Kicinski
2018-01-16 2:08 ` [PATCH bpf-next v2 09/11] nfp: bpf: use extack support to improve debugging Jakub Kicinski
2018-01-16 9:36 ` Jiri Pirko [this message]
2018-01-16 20:11 ` Jakub Kicinski
2018-01-17 4:06 ` David Ahern
2018-01-16 2:08 ` [PATCH bpf-next v2 10/11] netdevsim: add extack support for TC eBPF offload Jakub Kicinski
2018-01-16 2:08 ` [PATCH bpf-next v2 11/11] selftests/bpf: add checks on extack messages for eBPF hw offload tests Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180116093601.GB2477@nanopsycho \
--to=jiri@resnulli.us \
--cc=alexei.starovoitov@gmail.com \
--cc=aring@mojatatu.com \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=dsahern@gmail.com \
--cc=gerlitz.or@gmail.com \
--cc=jakub.kicinski@netronome.com \
--cc=jhs@mojatatu.com \
--cc=john.fastabend@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=oss-drivers@netronome.com \
--cc=quentin.monnet@netronome.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).