From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jiri Pirko Subject: Re: [PATCH bpf-next v2 09/11] nfp: bpf: use extack support to improve debugging Date: Tue, 16 Jan 2018 10:36:01 +0100 Message-ID: <20180116093601.GB2477@nanopsycho> References: <20180116020845.3496-1-jakub.kicinski@netronome.com> <20180116020845.3496-10-jakub.kicinski@netronome.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: davem@davemloft.net, daniel@iogearbox.net, alexei.starovoitov@gmail.com, netdev@vger.kernel.org, dsahern@gmail.com, oss-drivers@netronome.com, john.fastabend@gmail.com, jhs@mojatatu.com, gerlitz.or@gmail.com, aring@mojatatu.com, xiyou.wangcong@gmail.com, Quentin Monnet To: Jakub Kicinski Return-path: Received: from mail-wr0-f171.google.com ([209.85.128.171]:33738 "EHLO mail-wr0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750716AbeAPJgD (ORCPT ); Tue, 16 Jan 2018 04:36:03 -0500 Received: by mail-wr0-f171.google.com with SMTP id p6so14507558wrd.0 for ; Tue, 16 Jan 2018 01:36:02 -0800 (PST) Content-Disposition: inline In-Reply-To: <20180116020845.3496-10-jakub.kicinski@netronome.com> Sender: netdev-owner@vger.kernel.org List-ID: Tue, Jan 16, 2018 at 03:08:43AM CET, jakub.kicinski@netronome.com wrote: >From: Quentin Monnet > >Use the recently added extack support for eBPF offload in the driver. > >Signed-off-by: Quentin Monnet >Reviewed-by: Jakub Kicinski >--- [...] >@@ -303,7 +305,8 @@ static int nfp_net_bpf_load(struct nfp_net *nn, struct bpf_prog *prog) > /* Load up the JITed code */ > err = nfp_net_reconfig(nn, NFP_NET_CFG_UPDATE_BPF); > if (err) >- nn_err(nn, "FW command error while loading BPF: %d\n", err); >+ NL_SET_ERR_MSG_MOD(extack, >+ "FW command error while loading BPF"); One line please. Same for all others. Strings may overflow 80 cols.