From: Stephen Hemminger <stephen@networkplumber.org>
To: Luis de Bethencourt <luisbg@kernel.org>
Cc: linux-kernel@vger.kernel.org, Joe Perches <joe@perches.com>,
netdev@vger.kernel.org, "David S . Miller" <davem@davemloft.net>
Subject: Re: [PATCH] vxlan: Fix trailing semicolon
Date: Tue, 16 Jan 2018 09:48:38 -0800 [thread overview]
Message-ID: <20180116094839.0775faf2@xeon-e3> (raw)
In-Reply-To: <20180116150332.11242-1-luisbg@kernel.org>
On Tue, 16 Jan 2018 15:03:32 +0000
Luis de Bethencourt <luisbg@kernel.org> wrote:
> The trailing semicolon is an empty statement that does no operation.
> It is completely stripped out by the compiler. Removing it since it doesn't do
> anything.
>
> Signed-off-by: Luis de Bethencourt <luisbg@kernel.org>
> ---
>
> Hi,
>
> An other trailing semicolon to remove.
>
> Best regards
> Luis
>
>
> [0] http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2018-January/115410.html
> [1] http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2018-January/115390.html
>
> include/net/vxlan.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/net/vxlan.h b/include/net/vxlan.h
> index f96391e84a8a..ad73d8b3fcc2 100644
> --- a/include/net/vxlan.h
> +++ b/include/net/vxlan.h
> @@ -301,7 +301,7 @@ static inline netdev_features_t vxlan_features_check(struct sk_buff *skb,
> l4_hdr = ipv6_hdr(skb)->nexthdr;
> break;
> default:
> - return features;;
> + return features;
> }
>
> if ((l4_hdr == IPPROTO_UDP) &&
Fixes: 5f35227ea34b ("net: Generalize ndo_gso_check to ndo_features_check")
Acked-by: Stephen Hemminger <stephen@networkplumber.org>
next prev parent reply other threads:[~2018-01-16 17:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-16 15:03 [PATCH] vxlan: Fix trailing semicolon Luis de Bethencourt
2018-01-16 17:48 ` Stephen Hemminger [this message]
2018-01-17 21:07 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180116094839.0775faf2@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=davem@davemloft.net \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luisbg@kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).