* [PATCH] vxlan: Fix trailing semicolon
@ 2018-01-16 15:03 Luis de Bethencourt
2018-01-16 17:48 ` Stephen Hemminger
2018-01-17 21:07 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Luis de Bethencourt @ 2018-01-16 15:03 UTC (permalink / raw)
To: linux-kernel; +Cc: Joe Perches, netdev, David S . Miller, Luis de Bethencourt
The trailing semicolon is an empty statement that does no operation.
It is completely stripped out by the compiler. Removing it since it doesn't do
anything.
Signed-off-by: Luis de Bethencourt <luisbg@kernel.org>
---
Hi,
An other trailing semicolon to remove.
Best regards
Luis
[0] http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2018-January/115410.html
[1] http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2018-January/115390.html
include/net/vxlan.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/net/vxlan.h b/include/net/vxlan.h
index f96391e84a8a..ad73d8b3fcc2 100644
--- a/include/net/vxlan.h
+++ b/include/net/vxlan.h
@@ -301,7 +301,7 @@ static inline netdev_features_t vxlan_features_check(struct sk_buff *skb,
l4_hdr = ipv6_hdr(skb)->nexthdr;
break;
default:
- return features;;
+ return features;
}
if ((l4_hdr == IPPROTO_UDP) &&
--
2.15.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] vxlan: Fix trailing semicolon
2018-01-16 15:03 [PATCH] vxlan: Fix trailing semicolon Luis de Bethencourt
@ 2018-01-16 17:48 ` Stephen Hemminger
2018-01-17 21:07 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Stephen Hemminger @ 2018-01-16 17:48 UTC (permalink / raw)
To: Luis de Bethencourt; +Cc: linux-kernel, Joe Perches, netdev, David S . Miller
On Tue, 16 Jan 2018 15:03:32 +0000
Luis de Bethencourt <luisbg@kernel.org> wrote:
> The trailing semicolon is an empty statement that does no operation.
> It is completely stripped out by the compiler. Removing it since it doesn't do
> anything.
>
> Signed-off-by: Luis de Bethencourt <luisbg@kernel.org>
> ---
>
> Hi,
>
> An other trailing semicolon to remove.
>
> Best regards
> Luis
>
>
> [0] http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2018-January/115410.html
> [1] http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2018-January/115390.html
>
> include/net/vxlan.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/net/vxlan.h b/include/net/vxlan.h
> index f96391e84a8a..ad73d8b3fcc2 100644
> --- a/include/net/vxlan.h
> +++ b/include/net/vxlan.h
> @@ -301,7 +301,7 @@ static inline netdev_features_t vxlan_features_check(struct sk_buff *skb,
> l4_hdr = ipv6_hdr(skb)->nexthdr;
> break;
> default:
> - return features;;
> + return features;
> }
>
> if ((l4_hdr == IPPROTO_UDP) &&
Fixes: 5f35227ea34b ("net: Generalize ndo_gso_check to ndo_features_check")
Acked-by: Stephen Hemminger <stephen@networkplumber.org>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] vxlan: Fix trailing semicolon
2018-01-16 15:03 [PATCH] vxlan: Fix trailing semicolon Luis de Bethencourt
2018-01-16 17:48 ` Stephen Hemminger
@ 2018-01-17 21:07 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2018-01-17 21:07 UTC (permalink / raw)
To: luisbg; +Cc: linux-kernel, joe, netdev
From: Luis de Bethencourt <luisbg@kernel.org>
Date: Tue, 16 Jan 2018 15:03:32 +0000
> The trailing semicolon is an empty statement that does no operation.
> It is completely stripped out by the compiler. Removing it since it doesn't do
> anything.
>
> Signed-off-by: Luis de Bethencourt <luisbg@kernel.org>
Applied to net-next, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-01-17 21:07 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-01-16 15:03 [PATCH] vxlan: Fix trailing semicolon Luis de Bethencourt
2018-01-16 17:48 ` Stephen Hemminger
2018-01-17 21:07 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).