From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Subject: [PATCH net-next] bnxt_en: uninitialized variable in bnxt_rx_pkt() Date: Tue, 16 Jan 2018 13:38:59 +0300 Message-ID: <20180116103859.GA3374@mwanda> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: netdev@vger.kernel.org, kernel-janitors@vger.kernel.org To: Michael Chan , Andy Gospodarek Return-path: Received: from userp2120.oracle.com ([156.151.31.85]:49086 "EHLO userp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750908AbeAPKjJ (ORCPT ); Tue, 16 Jan 2018 05:39:09 -0500 Content-Disposition: inline Sender: netdev-owner@vger.kernel.org List-ID: There are a couple failure paths where "len" is used uninitialized. It means we record the number of rx_packets incorrectly. Fixes: 6a8788f25625 ("bnxt_en: add support for software dynamic interrupt moderation") Signed-off-by: Dan Carpenter diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethernet/broadcom/bnxt/bnxt.c index cf6ebf1e324b..5b5c4f266f1b 100644 --- a/drivers/net/ethernet/broadcom/bnxt/bnxt.c +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.c @@ -1482,7 +1482,7 @@ static int bnxt_rx_pkt(struct bnxt *bp, struct bnxt_napi *bnapi, u32 *raw_cons, u32 tmp_raw_cons = *raw_cons; u16 cfa_code, cons, prod, cp_cons = RING_CMP(tmp_raw_cons); struct bnxt_sw_rx_bd *rx_buf; - unsigned int len; + unsigned int len = 0; u8 *data_ptr, agg_bufs, cmp_type; dma_addr_t dma_addr; struct sk_buff *skb;