From mboxrd@z Thu Jan 1 00:00:00 1970 From: Guillaume Nault Subject: Re: [PATCH v2 net-next 0/5] l2tp: set l2specific_len based on l2specific_type Date: Tue, 16 Jan 2018 12:50:10 +0100 Message-ID: <20180116115010.GI1422@alphalink.fr> References: <20180116105538.GH1422@alphalink.fr> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: "David S. Miller" , netdev@vger.kernel.org, James Chapman To: Lorenzo Bianconi Return-path: Received: from zimbra.alphalink.fr ([217.15.80.77]:54474 "EHLO zimbra.alphalink.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750885AbeAPLuO (ORCPT ); Tue, 16 Jan 2018 06:50:14 -0500 Content-Disposition: inline In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: On Tue, Jan 16, 2018 at 12:45:06PM +0100, Lorenzo Bianconi wrote: > > On Sun, Jan 14, 2018 at 03:50:53PM +0100, Lorenzo Bianconi wrote: > >> Do not rely on l2specific_len value provided by userspace but set sublayer > >> length according to l2specific_type. > >> Fix a harmless issue in the switch default case in > >> l2tp_nl_cmd_session_create(). > >> > >> Changes since v1: > >> - remove l2specific_len parameter > >> - add sanity check on l2specific_type provided by userspace > >> > > Thanks for working on this Lorenzo. > > > > Whatever the discussions on patches 1 and 3 lead to: > > > > Reviewed-by: Guillaume Nault > > Tested-by: Guillaume Nault > > I will send a v3 later today dropping the first patch (I will send a > single one removing the switch later) and including your suggestion > for default case in l2tp_get_l2specific_len(). > Thanks for reviewing the patch :) > Great! Feel free to keep my Reviewed-by: and Tested-by: tags. Regards, Guillaume