From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Lunn Subject: Re: DPAA Ethernet traffice troubles with Linux kernel Date: Tue, 16 Jan 2018 15:38:36 +0100 Message-ID: <20180116143836.GC22903@lunn.ch> References: <1516035556.18795.71.camel@infinera.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: "linuxppc-dev@lists.ozlabs.org" , "madalin.bucur@nxp.com" , "madskateman@gmail.com" , "netdev@vger.kernel.org" To: Joakim Tjernlund Return-path: Received: from vps0.lunn.ch ([185.16.172.187]:50143 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751004AbeAPOio (ORCPT ); Tue, 16 Jan 2018 09:38:44 -0500 Content-Disposition: inline In-Reply-To: <1516035556.18795.71.camel@infinera.com> Sender: netdev-owner@vger.kernel.org List-ID: > Hi, just saw this and thought of a small patch I just wrote for mdio bus, o idea > if it is relevant but here goes: > > From fe0b98d54a79779482700676331b4d10a0f3cada Mon Sep 17 00:00:00 2001 > From: Joakim Tjernlund > Date: Sun, 14 Jan 2018 21:27:20 +0100 > Subject: [PATCH] of_mdiobus_register: Continue after error > > of_mdiobus_register unregister itself if one phy fails to register > which is bad for system having all its PHYs on the same MDIO bus. > Just log the error and continue with the remaining PHYs instead. > > Signed-off-by: Joakim Tjernlund Hi Joakim You appear to be using an old kernel. Take a look at: commit 95f566de0269a0c59fd6a737a147731302136429 Author: Madalin Bucur Date: Tue Jan 9 14:43:34 2018 +0200 of_mdio: avoid MDIO bus removal when a PHY is missing If one of the child devices is missing the of_mdiobus_register_phy() call will return -ENODEV. When a missing device is encountered the registration of the remaining PHYs is stopped and the MDIO bus will fail to register. Propagate all errors except ENODEV to avoid it. Signed-off-by: Madalin Bucur Reviewed-by: Andrew Lunn Signed-off-by: David S. Miller Andrew