From: Jiri Pirko <jiri@resnulli.us>
To: netdev@vger.kernel.org
Cc: davem@davemloft.net, jhs@mojatatu.com, xiyou.wangcong@gmail.com,
mlxsw@mellanox.com, andrew@lunn.ch,
vivien.didelot@savoirfairelinux.com, f.fainelli@gmail.com,
michael.chan@broadcom.com, ganeshgr@chelsio.com,
saeedm@mellanox.com, matanb@mellanox.com, leonro@mellanox.com,
idosch@mellanox.com, jakub.kicinski@netronome.com,
simon.horman@netronome.com, pieter.jansenvanvuuren@netronome.com,
john.hurley@netronome.com, alexander.h.duyck@intel.com,
ogerlitz@mellanox.com, john.fastabend@gmail.com,
daniel@iogearbox.net, dsahern@gmail.com
Subject: [patch net-next v10 05/13] net: sched: remove classid and q fields from tcf_proto
Date: Tue, 16 Jan 2018 16:33:08 +0100 [thread overview]
Message-ID: <20180116153316.4751-6-jiri@resnulli.us> (raw)
In-Reply-To: <20180116153316.4751-1-jiri@resnulli.us>
From: Jiri Pirko <jiri@mellanox.com>
Both are no longer used, so remove them.
Signed-off-by: Jiri Pirko <jiri@mellanox.com>
---
include/net/sch_generic.h | 2 --
net/sched/cls_api.c | 7 ++-----
2 files changed, 2 insertions(+), 7 deletions(-)
diff --git a/include/net/sch_generic.h b/include/net/sch_generic.h
index df97c3e..dba2214 100644
--- a/include/net/sch_generic.h
+++ b/include/net/sch_generic.h
@@ -255,8 +255,6 @@ struct tcf_proto {
/* All the rest */
u32 prio;
- u32 classid;
- struct Qdisc *q;
void *data;
const struct tcf_proto_ops *ops;
struct tcf_chain *chain;
diff --git a/net/sched/cls_api.c b/net/sched/cls_api.c
index 11bdb89..8a130e2 100644
--- a/net/sched/cls_api.c
+++ b/net/sched/cls_api.c
@@ -122,8 +122,7 @@ static inline u32 tcf_auto_prio(struct tcf_proto *tp)
}
static struct tcf_proto *tcf_proto_create(const char *kind, u32 protocol,
- u32 prio, u32 parent, struct Qdisc *q,
- struct tcf_chain *chain)
+ u32 prio, struct tcf_chain *chain)
{
struct tcf_proto *tp;
int err;
@@ -157,8 +156,6 @@ static struct tcf_proto *tcf_proto_create(const char *kind, u32 protocol,
tp->classify = tp->ops->classify;
tp->protocol = protocol;
tp->prio = prio;
- tp->classid = parent;
- tp->q = q;
tp->chain = chain;
err = tp->ops->init(tp);
@@ -1069,7 +1066,7 @@ static int tc_ctl_tfilter(struct sk_buff *skb, struct nlmsghdr *n,
prio = tcf_auto_prio(tcf_chain_tp_prev(&chain_info));
tp = tcf_proto_create(nla_data(tca[TCA_KIND]),
- protocol, prio, parent, q, chain);
+ protocol, prio, chain);
if (IS_ERR(tp)) {
err = PTR_ERR(tp);
goto errout;
--
2.9.5
next prev parent reply other threads:[~2018-01-16 15:33 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-16 15:33 [patch net-next v10 00/13] net: sched: allow qdiscs to share filter block instances Jiri Pirko
2018-01-16 15:33 ` [patch net-next v10 01/13] net: sched: introduce support for multiple filter chain pointers registration Jiri Pirko
2018-01-16 15:33 ` [patch net-next v10 02/13] net: sched: introduce shared filter blocks infrastructure Jiri Pirko
2018-01-17 0:03 ` Cong Wang
2018-01-17 8:59 ` Jiri Pirko
2018-01-16 15:33 ` [patch net-next v10 03/13] net: sched: avoid usage of tp->q in tcf_classify Jiri Pirko
2018-01-16 15:33 ` [patch net-next v10 04/13] net: sched: introduce block mechanism to handle netif_keep_dst calls Jiri Pirko
2018-01-16 15:33 ` Jiri Pirko [this message]
2018-01-16 15:33 ` [patch net-next v10 06/13] net: sched: keep track of offloaded filters and check tc offload feature Jiri Pirko
2018-01-16 15:33 ` [patch net-next v10 07/13] net: sched: use block index as a handle instead of qdisc when block is shared Jiri Pirko
2018-01-16 15:33 ` [patch net-next v10 08/13] net: sched: introduce ingress/egress block index attributes for qdisc Jiri Pirko
2018-01-16 15:33 ` [patch net-next v10 09/13] net: sched: allow ingress and clsact qdiscs to share filter blocks Jiri Pirko
2018-01-16 15:33 ` [patch net-next v10 10/13] mlxsw: spectrum_acl: Reshuffle code around mlxsw_sp_acl_ruleset_create/destroy Jiri Pirko
2018-01-16 15:33 ` [patch net-next v10 11/13] mlxsw: spectrum_acl: Don't store netdev and ingress for ruleset unbind Jiri Pirko
2018-01-16 15:33 ` [patch net-next v10 12/13] mlxsw: spectrum_acl: Implement TC block sharing Jiri Pirko
2018-01-16 15:33 ` [patch net-next v10 13/13] mlxsw: spectrum_acl: Pass mlxsw_sp_port down to ruleset bind/unbind ops Jiri Pirko
2018-01-16 15:34 ` [patch iproute2 net-next v10 1/4] include: update rtnetlink header according to kernel Jiri Pirko
2018-01-16 15:34 ` [patch iproute2 net-next v10 2/4] tc: introduce tc_qdisc_block_exists helper Jiri Pirko
2018-01-16 15:34 ` [patch iproute2 net-next v10 3/4] tc: introduce support for block-handle for filter operations Jiri Pirko
2018-01-16 15:34 ` [patch iproute2 net-next v10 4/4] tc: implement ingress/egress block index attributes for qdiscs Jiri Pirko
2018-01-16 23:33 ` [patch net-next v10 00/13] net: sched: allow qdiscs to share filter block instances Jamal Hadi Salim
2018-01-16 23:37 ` David Ahern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180116153316.4751-6-jiri@resnulli.us \
--to=jiri@resnulli.us \
--cc=alexander.h.duyck@intel.com \
--cc=andrew@lunn.ch \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=dsahern@gmail.com \
--cc=f.fainelli@gmail.com \
--cc=ganeshgr@chelsio.com \
--cc=idosch@mellanox.com \
--cc=jakub.kicinski@netronome.com \
--cc=jhs@mojatatu.com \
--cc=john.fastabend@gmail.com \
--cc=john.hurley@netronome.com \
--cc=leonro@mellanox.com \
--cc=matanb@mellanox.com \
--cc=michael.chan@broadcom.com \
--cc=mlxsw@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=ogerlitz@mellanox.com \
--cc=pieter.jansenvanvuuren@netronome.com \
--cc=saeedm@mellanox.com \
--cc=simon.horman@netronome.com \
--cc=vivien.didelot@savoirfairelinux.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).