From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jiri Pirko Subject: Re: [patch net-next v10 02/13] net: sched: introduce shared filter blocks infrastructure Date: Wed, 17 Jan 2018 09:59:50 +0100 Message-ID: <20180117085950.GA2114@nanopsycho> References: <20180116153316.4751-1-jiri@resnulli.us> <20180116153316.4751-3-jiri@resnulli.us> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Linux Kernel Network Developers , David Miller , Jamal Hadi Salim , mlxsw@mellanox.com, andrew@lunn.ch, Vivien Didelot , Florian Fainelli , michael.chan@broadcom.com, ganeshgr@chelsio.com, Saeed Mahameed , matanb@mellanox.com, leonro@mellanox.com, Ido Schimmel , Jakub Kicinski , Simon Horman , Pieter Jansen van Vuuren , john.hurley@netronome.com, Alexander Duyck , Or Gerlitz , John Fastabend , Daniel Borkmann Return-path: Received: from mail-wm0-f65.google.com ([74.125.82.65]:38321 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750861AbeAQI7w (ORCPT ); Wed, 17 Jan 2018 03:59:52 -0500 Received: by mail-wm0-f65.google.com with SMTP id 141so13936028wme.3 for ; Wed, 17 Jan 2018 00:59:52 -0800 (PST) Content-Disposition: inline In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: Wed, Jan 17, 2018 at 01:03:15AM CET, xiyou.wangcong@gmail.com wrote: >On Tue, Jan 16, 2018 at 7:33 AM, Jiri Pirko wrote: >> static int __init tc_filter_init(void) >> { >> + int err; >> + >> tc_filter_wq = alloc_ordered_workqueue("tc_filter_workqueue", 0); >> if (!tc_filter_wq) >> return -ENOMEM; >> >> + err = register_pernet_subsys(&tcf_net_ops); >> + if (err) >> + return err; > >Need to destroy the above workqueue on error. Will fix. Thanks.