From: Andrew Lunn <andrew@lunn.ch>
To: Marcin Wojtas <mw@semihalf.com>
Cc: linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org,
linux-acpi@vger.kernel.org, graeme.gregory@linaro.org,
davem@davemloft.net, linux@armlinux.org.uk,
rafael.j.wysocki@intel.com, f.fainelli@gmail.com,
antoine.tenart@free-electrons.com,
thomas.petazzoni@free-electrons.com,
gregory.clement@free-electrons.com, stefanc@marvell.com,
nadavh@marvell.com, neta@marvell.com, ard.biesheuvel@linaro.org,
jaz@semihalf.com, tn@semihalf.com
Subject: Re: [net-next: PATCH v3 0/7] Armada 7k/8k PP2 ACPI support
Date: Wed, 17 Jan 2018 21:20:39 +0100 [thread overview]
Message-ID: <20180117202039.GD5894@lunn.ch> (raw)
In-Reply-To: <1516208146-4144-1-git-send-email-mw@semihalf.com>
On Wed, Jan 17, 2018 at 05:55:39PM +0100, Marcin Wojtas wrote:
> Hi,
>
> This is a third version of the patchset introducing mvpp2 driver ability
> to operate with ACPI. Until follow-up generic MDIO is introduced
> it can using the link interrupt capability (a.k.a. in-band management)
> on all ports, 1000BaseT RGMII included.
> Driver operation was tested on top of the net-next branch
> with both DT and ACPI on MacchiatoBin and Armada 7040 DB boards.
>
> The main changes were requested during v2 review, which was
> adding generic helper routines for:
> * interating over available fwnodes (new patch 4/7)
> * getting IRQ directly from fwnode (new patch 3/7)
> Thanks to the latter the driver code could be simplified
> and allowed to drop formula-based IRQ obtaining. Changes are
> summarized in the changelog below.
Hi Marcin
I don't know enough about ACPI to make a proper review of the changes.
But it does at least all look sensible.
Andrew
next prev parent reply other threads:[~2018-01-17 20:20 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-17 16:55 [net-next: PATCH v3 0/7] Armada 7k/8k PP2 ACPI support Marcin Wojtas
2018-01-17 16:55 ` [net-next: PATCH v3 1/7] device property: Introduce fwnode_get_mac_address() Marcin Wojtas
2018-01-17 16:55 ` [net-next: PATCH v3 2/7] device property: Introduce fwnode_get_phy_mode() Marcin Wojtas
2018-01-17 16:55 ` [net-next: PATCH v3 3/7] device property: Introduce fwnode_irq_get() Marcin Wojtas
2018-01-17 16:55 ` [net-next: PATCH v3 4/7] device property: Allow iterating over available child fwnodes Marcin Wojtas
2018-01-17 16:55 ` [net-next: PATCH v3 5/7] net: mvpp2: simplify maintaining enabled ports' list Marcin Wojtas
2018-01-17 16:55 ` [net-next: PATCH v3 6/7] net: mvpp2: use device_*/fwnode_* APIs instead of of_* Marcin Wojtas
2018-01-17 16:55 ` [net-next: PATCH v3 7/7] net: mvpp2: enable ACPI support in the driver Marcin Wojtas
2018-01-17 18:11 ` [net-next: PATCH v3 0/7] Armada 7k/8k PP2 ACPI support Andrew Lunn
2018-01-17 19:03 ` Marcin Wojtas
2018-01-17 20:20 ` Andrew Lunn [this message]
2018-01-18 15:53 ` graeme.gregory
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180117202039.GD5894@lunn.ch \
--to=andrew@lunn.ch \
--cc=antoine.tenart@free-electrons.com \
--cc=ard.biesheuvel@linaro.org \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=graeme.gregory@linaro.org \
--cc=gregory.clement@free-electrons.com \
--cc=jaz@semihalf.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mw@semihalf.com \
--cc=nadavh@marvell.com \
--cc=neta@marvell.com \
--cc=netdev@vger.kernel.org \
--cc=rafael.j.wysocki@intel.com \
--cc=stefanc@marvell.com \
--cc=thomas.petazzoni@free-electrons.com \
--cc=tn@semihalf.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).