From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jiri Pirko Subject: Re: [RFC PATCH net-next 02/12] selftests: forwarding: Add a test for FDB learning Date: Wed, 17 Jan 2018 22:01:37 +0100 Message-ID: <20180117210137.GJ2114@nanopsycho> References: <20180115191853.26129-1-idosch@mellanox.com> <20180115191853.26129-3-idosch@mellanox.com> <33d3f4a4-8b92-60da-3e1f-327effb7eda0@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Ido Schimmel , netdev@vger.kernel.org, linux-kselftest@vger.kernel.org, davem@davemloft.net, shuah@kernel.org, nikolay@cumulusnetworks.com, roopa@cumulusnetworks.com, andy@greyhouse.net, jiri@mellanox.com, mlxsw@mellanox.com, saeedm@mellanox.com, tariqt@mellanox.com, jhs@mojatatu.com, lucasb@mojatatu.com, f.fainelli@gmail.com, vivien.didelot@savoirfairelinux.com, andrew@lunn.ch, jakub.kicinski@netronome.com, simon.horman@netronome.com To: David Ahern Return-path: Received: from mail-wr0-f177.google.com ([209.85.128.177]:39073 "EHLO mail-wr0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754190AbeAQVBm (ORCPT ); Wed, 17 Jan 2018 16:01:42 -0500 Received: by mail-wr0-f177.google.com with SMTP id z48so20374543wrz.6 for ; Wed, 17 Jan 2018 13:01:41 -0800 (PST) Content-Disposition: inline In-Reply-To: <33d3f4a4-8b92-60da-3e1f-327effb7eda0@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: Wed, Jan 17, 2018 at 09:48:54PM CET, dsahern@gmail.com wrote: >On 1/15/18 11:18 AM, Ido Schimmel wrote: >> diff --git a/tools/testing/selftests/forwarding/lib.sh b/tools/testing/selftests/forwarding/lib.sh >> index bb423371f4de..264bf0af4c4d 100644 >> --- a/tools/testing/selftests/forwarding/lib.sh >> +++ b/tools/testing/selftests/forwarding/lib.sh >> @@ -22,6 +22,11 @@ if [[ ! -x "$(command -v jq)" ]]; then >> exit 0 >> fi >> >> +if [[ ! -x "$(command -v mausezahn)" ]]; then >> + echo "SKIP: mausezahn not installed" >> + exit 0 >> +fi >> + > >The checks are good, but hitting a collision with this one: >$ ./router.sh >SKIP: mausezahn not installed > >For debian, it is mz not mausezahn. That is weird. If you look at the sources, the binary name is "mausezahn". Looks like debian is doing some renaming :/