From: Jiri Pirko <jiri@resnulli.us>
To: Roopa Prabhu <roopa@cumulusnetworks.com>
Cc: David Ahern <dsahern@gmail.com>,
Ido Schimmel <idosch@mellanox.com>,
netdev@vger.kernel.org, linux-kselftest@vger.kernel.org,
David Miller <davem@davemloft.net>,
shuah@kernel.org,
Nikolay Aleksandrov <nikolay@cumulusnetworks.com>,
Andy Gospodarek <andy@greyhouse.net>,
Jiri Pirko <jiri@mellanox.com>, mlxsw <mlxsw@mellanox.com>,
Saeed Mahameed <saeedm@mellanox.com>,
tariqt@mellanox.com, Jamal Hadi Salim <jhs@mojatatu.com>,
Lucas Bates <lucasb@mojatatu.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Vivien Didelot <vivien.didelot@savoirfairelinux.com>,
Andrew Lunn <andrew@lunn.ch>,
jakub.kicinski@netronome.com,
Simon Horman <simon.horman@netronome.com>
Subject: Re: [RFC PATCH net-next 02/12] selftests: forwarding: Add a test for FDB learning
Date: Thu, 18 Jan 2018 00:31:24 +0100 [thread overview]
Message-ID: <20180117233124.GA26967@nanopsycho> (raw)
In-Reply-To: <CAJieiUiB14Js0hTk7E_4+AmyAZbjHTCE_MWpU-=7FbMsjvHB2w@mail.gmail.com>
Wed, Jan 17, 2018 at 11:59:10PM CET, roopa@cumulusnetworks.com wrote:
>On Wed, Jan 17, 2018 at 2:46 PM, Roopa Prabhu <roopa@cumulusnetworks.com> wrote:
>> On Wed, Jan 17, 2018 at 1:01 PM, Jiri Pirko <jiri@resnulli.us> wrote:
>>> Wed, Jan 17, 2018 at 09:48:54PM CET, dsahern@gmail.com wrote:
>>>>On 1/15/18 11:18 AM, Ido Schimmel wrote:
>>>>> diff --git a/tools/testing/selftests/forwarding/lib.sh b/tools/testing/selftests/forwarding/lib.sh
>>>>> index bb423371f4de..264bf0af4c4d 100644
>>>>> --- a/tools/testing/selftests/forwarding/lib.sh
>>>>> +++ b/tools/testing/selftests/forwarding/lib.sh
>>>>> @@ -22,6 +22,11 @@ if [[ ! -x "$(command -v jq)" ]]; then
>>>>> exit 0
>>>>> fi
>>>>>
>>>>> +if [[ ! -x "$(command -v mausezahn)" ]]; then
>>>>> + echo "SKIP: mausezahn not installed"
>>>>> + exit 0
>>>>> +fi
>>>>> +
>>>>
>>>>The checks are good, but hitting a collision with this one:
>>>>$ ./router.sh
>>>>SKIP: mausezahn not installed
>>>>
>>>>For debian, it is mz not mausezahn.
>>>
>>> That is weird. If you look at the sources, the binary name is
>>> "mausezahn". Looks like debian is doing some renaming :/
>>>
>>
>> I have seen/used both versions. Debian packages from some old upstream
>> source which calls it mz.
>> https://packages.debian.org/sid/main/mz
>>
>> I have used latest mz (with ipv6 support etc) from netsniff-ng which
>> builds it as mausezahn.
>
>
>actually Debian also builds
>https://packages.debian.org/sid/netsniff-ng and installs 'mausezahn'
>
>so you might have to check and use which exists... (mausezahn overriding mz).
I believe we can stick with mausezahn, since it is apparently
available on Debian too.
next prev parent reply other threads:[~2018-01-17 23:31 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-15 19:18 [RFC PATCH net-next 00/12] selftests: forwarding: Add VRF-based tests Ido Schimmel
2018-01-15 19:18 ` [RFC PATCH net-next 01/12] selftests: forwarding: Add initial testing framework Ido Schimmel
2018-01-17 20:56 ` David Ahern
2018-01-17 21:18 ` Andrew Lunn
2018-01-17 21:26 ` David Ahern
2018-01-15 19:18 ` [RFC PATCH net-next 02/12] selftests: forwarding: Add a test for FDB learning Ido Schimmel
2018-01-15 19:41 ` Andrew Lunn
2018-01-15 20:05 ` Ido Schimmel
2018-01-15 21:01 ` Andrew Lunn
2018-01-17 20:48 ` David Ahern
2018-01-17 21:01 ` Jiri Pirko
2018-01-17 22:46 ` Roopa Prabhu
2018-01-17 22:59 ` Roopa Prabhu
2018-01-17 23:31 ` Jiri Pirko [this message]
2018-01-18 0:15 ` David Ahern
2018-01-18 7:16 ` Ido Schimmel
2018-01-18 7:51 ` Jiri Pirko
2018-01-15 19:18 ` [RFC PATCH net-next 03/12] selftests: forwarding: Add a test for flooded traffic Ido Schimmel
2018-01-15 19:18 ` [RFC PATCH net-next 04/12] selftests: forwarding: Add a test for basic IPv4 and IPv6 routing Ido Schimmel
2018-01-15 19:18 ` [RFC PATCH net-next 05/12] selftests: forwarding: Create test topology for multipath routing Ido Schimmel
2018-01-15 19:18 ` [RFC PATCH net-next 06/12] selftests: forwarding: Test IPv4 weighted nexthops Ido Schimmel
2018-01-15 19:18 ` [RFC PATCH net-next 07/12] selftests: forwarding: Test IPv6 " Ido Schimmel
2018-01-15 19:18 ` [RFC PATCH net-next 08/12] selftests: forwarding: Add tc offload check helper Ido Schimmel
2018-01-15 19:18 ` [RFC PATCH net-next 09/12] selftests: forwarding: Add MAC get helper Ido Schimmel
2018-01-15 19:18 ` [RFC PATCH net-next 10/12] selftests: forwarding: Allow to get netdev interfaces names from commandline Ido Schimmel
2018-01-15 19:18 ` [RFC PATCH net-next 11/12] selftests: forwarding: Allow to pass commandline options Ido Schimmel
2018-01-15 19:18 ` [RFC PATCH net-next 12/12] selftests: forwarding: Introduce tc flower matching tests Ido Schimmel
2018-01-15 20:14 ` [RFC PATCH net-next 00/12] selftests: forwarding: Add VRF-based tests David Ahern
2018-01-15 23:17 ` Jiri Pirko
2018-01-15 23:48 ` David Ahern
2018-01-16 7:59 ` Ido Schimmel
2018-01-17 22:51 ` Florian Fainelli
2018-01-17 23:11 ` Andrew Lunn
2018-01-18 7:41 ` Ido Schimmel
2018-01-18 12:46 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180117233124.GA26967@nanopsycho \
--to=jiri@resnulli.us \
--cc=andrew@lunn.ch \
--cc=andy@greyhouse.net \
--cc=davem@davemloft.net \
--cc=dsahern@gmail.com \
--cc=f.fainelli@gmail.com \
--cc=idosch@mellanox.com \
--cc=jakub.kicinski@netronome.com \
--cc=jhs@mojatatu.com \
--cc=jiri@mellanox.com \
--cc=linux-kselftest@vger.kernel.org \
--cc=lucasb@mojatatu.com \
--cc=mlxsw@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=nikolay@cumulusnetworks.com \
--cc=roopa@cumulusnetworks.com \
--cc=saeedm@mellanox.com \
--cc=shuah@kernel.org \
--cc=simon.horman@netronome.com \
--cc=tariqt@mellanox.com \
--cc=vivien.didelot@savoirfairelinux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).