From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net] netlink: reset extack earlier in netlink_rcv_skb Date: Thu, 18 Jan 2018 15:15:30 -0500 (EST) Message-ID: <20180118.151530.874858700823598859.davem@davemloft.net> References: <19a629d2b8f53141d60f3896a62152f372d071b9.1516258083.git.lucien.xin@gmail.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: lucien.xin@gmail.com, netdev@vger.kernel.org To: dsahern@gmail.com Return-path: Received: from shards.monkeyblade.net ([184.105.139.130]:57132 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750951AbeARUPe (ORCPT ); Thu, 18 Jan 2018 15:15:34 -0500 In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: From: David Ahern Date: Thu, 18 Jan 2018 09:10:51 -0800 > On 1/17/18 10:48 PM, Xin Long wrote: >> Move up the extack reset/initialization in netlink_rcv_skb, so that >> those 'goto ack' will not skip it. Otherwise, later on netlink_ack >> may use the uninitialized extack and cause kernel crash. >> >> Fixes: cbbdf8433a5f ("netlink: extack needs to be reset each time through loop") >> Reported-by: syzbot+03bee3680a37466775e7@syzkaller.appspotmail.com >> Signed-off-by: Xin Long >> --- >> net/netlink/af_netlink.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> > > Acked-by: David Ahern Applied and queued up for -stable, thank you.