From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net] ipv6: don't let tb6_root node share routes with other node Date: Thu, 18 Jan 2018 21:14:46 -0500 (EST) Message-ID: <20180118.211446.1437094078738888938.davem@davemloft.net> References: <20180118184003.82818-1-tracywwnj@gmail.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, edumazet@google.com, kafai@fb.com To: weiwan@google.com Return-path: Received: from shards.monkeyblade.net ([184.105.139.130]:33790 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754094AbeASCOs (ORCPT ); Thu, 18 Jan 2018 21:14:48 -0500 In-Reply-To: <20180118184003.82818-1-tracywwnj@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: From: Wei Wang Date: Thu, 18 Jan 2018 10:40:03 -0800 > From: Wei Wang > > After commit 4512c43eac7e, if we add a route to the subtree of tb6_root > which does not have any route attached to it yet, the current code will > let tb6_root and the node in the subtree share the same route. > This could cause problem cause tb6_root has RTN_INFO flag marked and the > tree repair and clean up code will not work properly. > This commit makes sure tb6_root->leaf points back to null_entry instead > of sharing route with other node. > > It fixes the following syzkaller reported issue: ... > Fixes: 4512c43eac7e ("ipv6: remove null_entry before adding default route") > Signed-off-by: Wei Wang > Acked-by: Eric Dumazet Applied, thank you.