From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ido Schimmel Subject: Re: [RFC PATCH net-next 02/12] selftests: forwarding: Add a test for FDB learning Date: Thu, 18 Jan 2018 09:16:54 +0200 Message-ID: <20180118071654.GA5379@splinter> References: <20180115191853.26129-1-idosch@mellanox.com> <20180115191853.26129-3-idosch@mellanox.com> <33d3f4a4-8b92-60da-3e1f-327effb7eda0@gmail.com> <20180117210137.GJ2114@nanopsycho> <20180117233124.GA26967@nanopsycho> <9e1bfed9-34a3-5810-230e-0bef75a43fb9@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Jiri Pirko , Roopa Prabhu , Ido Schimmel , netdev@vger.kernel.org, linux-kselftest@vger.kernel.org, David Miller , shuah@kernel.org, Nikolay Aleksandrov , Andy Gospodarek , Jiri Pirko , mlxsw , Saeed Mahameed , tariqt@mellanox.com, Jamal Hadi Salim , Lucas Bates , Florian Fainelli , Vivien Didelot , Andrew Lunn , jakub.kicinski@netronome.com, Simon Horman To: David Ahern Return-path: Received: from out1-smtp.messagingengine.com ([66.111.4.25]:52927 "EHLO out1-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752513AbeARHQ5 (ORCPT ); Thu, 18 Jan 2018 02:16:57 -0500 Content-Disposition: inline In-Reply-To: <9e1bfed9-34a3-5810-230e-0bef75a43fb9@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: On Wed, Jan 17, 2018 at 04:15:04PM -0800, David Ahern wrote: > How about the attached - make ping, ping6 and mz variables? Default to > ping and mausezahn but let users update that name if necessary. Comments > in the sample config to the effect need to be added to help users. Yes, looks good to me. Will include the change in the next version. Thanks!