From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jiri Pirko Subject: Re: [PATCH net+iproute2 0/2] nbyte, cmp and text filter fixups Date: Thu, 18 Jan 2018 11:59:40 +0100 Message-ID: <20180118105940.GA2024@nanopsycho> References: <20180118103236.32494-1-w.bumiller@proxmox.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: netdev@vger.kernel.org, Stephen Hemminger , Jamal Hadi Salim , Cong Wang , "David S . Miller" To: Wolfgang Bumiller Return-path: Received: from mail-wr0-f174.google.com ([209.85.128.174]:45457 "EHLO mail-wr0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754920AbeARK7m (ORCPT ); Thu, 18 Jan 2018 05:59:42 -0500 Received: by mail-wr0-f174.google.com with SMTP id 16so22076340wry.12 for ; Thu, 18 Jan 2018 02:59:42 -0800 (PST) Content-Disposition: inline In-Reply-To: <20180118103236.32494-1-w.bumiller@proxmox.com> Sender: netdev-owner@vger.kernel.org List-ID: Thu, Jan 18, 2018 at 11:32:33AM CET, w.bumiller@proxmox.com wrote: >The iproute2 part allows the the actual use of the already existing >quoted string parsing. Makes no sense to send iproute2 patch which is not related with the kernel ones in the same set. Please send it separatelly. > >The kernel side fixes an oob read in em_nbyte and allows 'layer 0' in >cmp and nbyte (and em_text whose existence surprised me given that I did >not see it exposed via iproute2) to actually match layer 0 rather than >being the same as specifying layer 1. > >I seem to have stumbled upon a layer of dust (says git-blame). >Trying to match mac addresses I felt that the examples found online >using the 'u32' filter were rather inconvenient, particularly given >that there's the 'nbyte' filter around that could just memcmp the >entire a byte sequence at once. > >Wolfgang Bumiller (1; 2): > tc/lexer: let quotes actually start strings > > tc/emp_ematch.l | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > net: sched: em_nbyte: don't add the data offset twice > net_sched: fix TCF_LAYER_LINK case in tcf_get_base_ptr "net: sched:" or "net_sched:"? - please, try to be consistent