From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jakub Kicinski <kubakici@wp.pl>
Subject: Re: [PATCHv3 net-next 0/7] net: sched: cls: add extack support
Date: Thu, 18 Jan 2018 12:15:30 -0800
Message-ID: <20180118121530.00a2a20f@cakuba.netronome.com>
References: <20180118162055.31587-1-aring@mojatatu.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: jhs@mojatatu.com, xiyou.wangcong@gmail.com, jiri@resnulli.us,
        davem@davemloft.net, netdev@vger.kernel.org, kernel@mojatatu.com,
        David Ahern <dsahern@gmail.com>
To: Alexander Aring <aring@mojatatu.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mx4.wp.pl ([212.77.101.11]:55009 "EHLO mx4.wp.pl"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S932322AbeARUPj (ORCPT <rfc822;netdev@vger.kernel.org>);
        Thu, 18 Jan 2018 15:15:39 -0500
In-Reply-To: <20180118162055.31587-1-aring@mojatatu.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Thu, 18 Jan 2018 11:20:48 -0500, Alexander Aring wrote:
> Hi,
> 
> this patch adds extack support for TC classifier subsystem. The first
> patch fixes some code style issues for this patch series pointed out
> by checkpatch. The other patches until the last one prepares extack
> handling for the TC classifier subsystem and handle generic extack
> errors.
> 
> The last patch is an example for u32 classifier to add extack support
> inside the callbacks delete and change. There exists a init callback as
> well, but most classifier implementation run a kalloc() once to allocate
> something. Not necessary _yet_ to add extack support now.
> 
> - Alex
> 
> Cc: David Ahern <dsahern@gmail.com>
> 
> changes since v3:
>  - fix accidentally move of config option mismatch message in PATCH 2/8
>    correct one is 4/8, detected by kbuildbot (Thank you)
>  - Removed patch "net: sched: cls: add extack support for tc_setup_cb_call"
>    PATCH 7/8 in version v2 as suggested by Jakub Kicinski (Thank you)
>  - changed NL_SET_ERR_MSG to NL_SET_ERR_MSG_MOD as suggested by Jakub Kicinski
>    in u32 cls (Thank You)
>  - Removed text from cover letter that I was waiting for Jiri's Patches as
>    detected by Jamal Hadi Salim (Thank you).

LGTM now, thank you!