From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH] bridge: return boolean instead of integer in br_multicast_is_router Date: Thu, 18 Jan 2018 16:22:50 -0800 Message-ID: <20180118162250.013954dd@xeon-e3> References: <20180118233745.GA23355@embeddedor.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: "David S. Miller" , bridge@lists.linux-foundation.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org To: "Gustavo A. R. Silva" Return-path: Received: from mail-pg0-f67.google.com ([74.125.83.67]:46302 "EHLO mail-pg0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750784AbeASAW6 (ORCPT ); Thu, 18 Jan 2018 19:22:58 -0500 Received: by mail-pg0-f67.google.com with SMTP id s9so9046pgq.13 for ; Thu, 18 Jan 2018 16:22:58 -0800 (PST) In-Reply-To: <20180118233745.GA23355@embeddedor.com> Sender: netdev-owner@vger.kernel.org List-ID: On Thu, 18 Jan 2018 17:37:45 -0600 "Gustavo A. R. Silva" wrote: > Return statements in functions returning bool should use > true/false instead of 1/0. > > This issue was detected with the help of Coccinelle. > > Signed-off-by: Gustavo A. R. Silva LGTM Fixes: 85b352693264 ("bridge: Fix build error when IGMP_SNOOPING is not enabled") Reviewed-by: Stephen Hemminger