From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH iproute2 v2 0/9] ip/tunnel: Improve tunnel parameters printing Date: Thu, 18 Jan 2018 16:35:27 -0800 Message-ID: <20180118163527.69110150@xeon-e3> References: <1516284276-10942-1-git-send-email-serhe.popovych@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org To: Serhey Popovych Return-path: Received: from mail-pg0-f42.google.com ([74.125.83.42]:46829 "EHLO mail-pg0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754426AbeASAfg (ORCPT ); Thu, 18 Jan 2018 19:35:36 -0500 Received: by mail-pg0-f42.google.com with SMTP id s9so33168pgq.13 for ; Thu, 18 Jan 2018 16:35:35 -0800 (PST) In-Reply-To: <1516284276-10942-1-git-send-email-serhe.popovych@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: On Thu, 18 Jan 2018 16:04:27 +0200 Serhey Popovych wrote: > Continue improvements to tunnel modules. Final goal > is to make merge IP and IPv6 variants and make that > transition as transparent as possible. > > Everything within this series is open for your comments, > suggestions and criticism. > > See individual patch description message for details. > > v2 > 1) Fix checkpatch issues: no assignment in condtional > anymore. > > 2) Better code abstraction: introduce tnl_print_encap() > helper and get rid of duplicated code for printing > tunnel encapsulation options. > > Patch with subject > "ip/tunnel: Abstract tunnel encapsulation options printing" > replaces two previous in v1 series > "ip/tunnel: Use print_string() and simplify encap option printing" > and > "ip/tunnel: Minor cleanups in print routines" > > 3) Include patch with subject > "tunnel: Return constant string without copying it" > in the series: it is related to tunneling code too. > > Thanks, > Serhii > > Serhey Popovych (9): > iplink: Use ll_index_to_name() instead of if_indextoname() > ip/tunnel: Correct and unify ttl/hoplimit printing > ip/tunnel: Simplify and unify tos printing > ip/tunnel: Use print_0xhex() instead of print_string() > ip/tunnel: Abstract tunnel encapsulation options printing > gre/tunnel: Print erspan_index using print_uint() > vti/tunnel: Unify ikey/okey printing > vti6/tunnel: Unify and simplify link type help functions > tunnel: Return constant string without copying it > > bridge/fdb.c | 5 +- > bridge/link.c | 19 +++---- > ip/ip6tunnel.c | 5 +- > ip/iplink_bond.c | 38 ++++++-------- > ip/iplink_geneve.c | 38 ++++++-------- > ip/iplink_vxlan.c | 49 ++++++++---------- > ip/iproute_lwtunnel.c | 11 ++--- > ip/iptunnel.c | 2 +- > ip/link_gre.c | 132 +++++++++++-------------------------------------- > ip/link_gre6.c | 103 +++++++++----------------------------- > ip/link_ip6tnl.c | 105 ++++++++++----------------------------- > ip/link_iptnl.c | 128 +++++++++++------------------------------------ > ip/link_vti.c | 42 ++++++++-------- > ip/link_vti6.c | 64 +++++++++++++++--------- > ip/tunnel.c | 116 ++++++++++++++++++++++++++++++++++++------- > ip/tunnel.h | 5 ++ > 16 files changed, 340 insertions(+), 522 deletions(-) > This looks fine. Thanks for following up. Applied.