From mboxrd@z Thu Jan 1 00:00:00 1970 From: Richard Cochran Subject: Re: [RFC v2 net-next 01/10] net: Add a new socket option for a future transmit time. Date: Thu, 18 Jan 2018 09:11:22 -0800 Message-ID: <20180118171122.3pnrws3o3dvh54u2@localhost> References: <20180117230621.26074-1-jesus.sanchez-palencia@intel.com> <20180117230621.26074-2-jesus.sanchez-palencia@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: netdev@vger.kernel.org, jhs@mojatatu.com, xiyou.wangcong@gmail.com, jiri@resnulli.us, vinicius.gomes@intel.com, intel-wired-lan@lists.osuosl.org, anna-maria@linutronix.de, henrik@austad.us, tglx@linutronix.de, john.stultz@linaro.org, andre.guedes@intel.com, ivan.briano@intel.com, levi.pearson@harman.com, Richard Cochran To: Jesus Sanchez-Palencia Return-path: Received: from mail-pf0-f194.google.com ([209.85.192.194]:32893 "EHLO mail-pf0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755004AbeARRL0 (ORCPT ); Thu, 18 Jan 2018 12:11:26 -0500 Received: by mail-pf0-f194.google.com with SMTP id t5so8974091pfi.0 for ; Thu, 18 Jan 2018 09:11:26 -0800 (PST) Content-Disposition: inline In-Reply-To: <20180117230621.26074-2-jesus.sanchez-palencia@intel.com> Sender: netdev-owner@vger.kernel.org List-ID: On Wed, Jan 17, 2018 at 03:06:12PM -0800, Jesus Sanchez-Palencia wrote: > @@ -2130,6 +2137,15 @@ int __sock_cmsg_send(struct sock *sk, struct msghdr *msg, struct cmsghdr *cmsg, > sockc->tsflags &= ~SOF_TIMESTAMPING_TX_RECORD_MASK; > sockc->tsflags |= tsflags; > break; > + case SO_TXTIME: > + if (!ns_capable(sock_net(sk)->user_ns, CAP_NET_ADMIN)) > + return -EPERM; > + if (!sock_flag(sk, SOCK_TXTIME)) > + return -EINVAL; > + if (cmsg->cmsg_len != CMSG_LEN(sizeof(ktime_t))) > + return -EINVAL; > + sockc->transmit_time = *(ktime_t *)CMSG_DATA(cmsg); As pointed out in the first series' review: No guarantee the CMSG is properly aligned on arches that might trap on unaligned access. Thanks, Richard