From mboxrd@z Thu Jan  1 00:00:00 1970
From: Richard Cochran <richardcochran@gmail.com>
Subject: Re: [RFC v2 net-next 06/10] net/sched: Introduce the TBS Qdisc
Date: Thu, 18 Jan 2018 09:18:35 -0800
Message-ID: <20180118171835.rzpb5t5ejddl4ye6@localhost>
References: <20180117230621.26074-1-jesus.sanchez-palencia@intel.com>
 <20180117230621.26074-7-jesus.sanchez-palencia@intel.com>
 <30e104db-3c88-b2f7-4494-98b2bece8ca9@mojatatu.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Jesus Sanchez-Palencia <jesus.sanchez-palencia@intel.com>,
        netdev@vger.kernel.org, xiyou.wangcong@gmail.com, jiri@resnulli.us,
        vinicius.gomes@intel.com, intel-wired-lan@lists.osuosl.org,
        anna-maria@linutronix.de, henrik@austad.us, tglx@linutronix.de,
        john.stultz@linaro.org, andre.guedes@intel.com,
        ivan.briano@intel.com, levi.pearson@harman.com
To: Jamal Hadi Salim <jhs@mojatatu.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-pg0-f45.google.com ([74.125.83.45]:40793 "EHLO
        mail-pg0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1750841AbeARRSi (ORCPT
        <rfc822;netdev@vger.kernel.org>); Thu, 18 Jan 2018 12:18:38 -0500
Received: by mail-pg0-f45.google.com with SMTP id g16so8178096pgn.7
        for <netdev@vger.kernel.org>; Thu, 18 Jan 2018 09:18:38 -0800 (PST)
Content-Disposition: inline
In-Reply-To: <30e104db-3c88-b2f7-4494-98b2bece8ca9@mojatatu.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Thu, Jan 18, 2018 at 08:35:18AM -0500, Jamal Hadi Salim wrote:
> 1) iproute2: Avoid magic numbers like 1 or 11 please; "offload"
> (without 1) and "TAI" will be more human friendly.

Yes, and for the clockid, the program should accept CLOCK_REALTIME or
CLOCK_TAI for the hard coded SYS-V IDs or /dev/ptp0 for dynamic IDs.

Thanks,
Richard