* [PATCH net-next] devlink: Make some functions static
@ 2018-01-17 3:27 Wei Yongjun
2018-01-17 15:32 ` Jiri Pirko
2018-01-19 19:52 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Wei Yongjun @ 2018-01-17 3:27 UTC (permalink / raw)
To: Jiri Pirko; +Cc: Wei Yongjun, netdev, kernel-janitors
Fixes the following sparse warnings:
net/core/devlink.c:2297:25: warning:
symbol 'devlink_resource_find' was not declared. Should it be static?
net/core/devlink.c:2322:6: warning:
symbol 'devlink_resource_validate_children' was not declared. Should it be static?
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
net/core/devlink.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/net/core/devlink.c b/net/core/devlink.c
index dd7d6dd..66d3670 100644
--- a/net/core/devlink.c
+++ b/net/core/devlink.c
@@ -2294,7 +2294,7 @@ static int devlink_nl_cmd_dpipe_table_counters_set(struct sk_buff *skb,
counters_enable);
}
-struct devlink_resource *
+static struct devlink_resource *
devlink_resource_find(struct devlink *devlink,
struct devlink_resource *resource, u64 resource_id)
{
@@ -2319,7 +2319,8 @@ struct devlink_resource *
return NULL;
}
-void devlink_resource_validate_children(struct devlink_resource *resource)
+static void
+devlink_resource_validate_children(struct devlink_resource *resource)
{
struct devlink_resource *child_resource;
bool size_valid = true;
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH net-next] devlink: Make some functions static
2018-01-17 3:27 [PATCH net-next] devlink: Make some functions static Wei Yongjun
@ 2018-01-17 15:32 ` Jiri Pirko
2018-01-19 19:52 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Jiri Pirko @ 2018-01-17 15:32 UTC (permalink / raw)
To: Wei Yongjun; +Cc: Jiri Pirko, netdev, kernel-janitors
Wed, Jan 17, 2018 at 04:27:42AM CET, weiyongjun1@huawei.com wrote:
>Fixes the following sparse warnings:
>
>net/core/devlink.c:2297:25: warning:
> symbol 'devlink_resource_find' was not declared. Should it be static?
>net/core/devlink.c:2322:6: warning:
> symbol 'devlink_resource_validate_children' was not declared. Should it be static?
>
>Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Acked-by: Jiri Pirko <jiri@mellanox.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] devlink: Make some functions static
2018-01-17 3:27 [PATCH net-next] devlink: Make some functions static Wei Yongjun
2018-01-17 15:32 ` Jiri Pirko
@ 2018-01-19 19:52 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2018-01-19 19:52 UTC (permalink / raw)
To: weiyongjun1; +Cc: jiri, netdev, kernel-janitors
From: Wei Yongjun <weiyongjun1@huawei.com>
Date: Wed, 17 Jan 2018 03:27:42 +0000
> Fixes the following sparse warnings:
>
> net/core/devlink.c:2297:25: warning:
> symbol 'devlink_resource_find' was not declared. Should it be static?
> net/core/devlink.c:2322:6: warning:
> symbol 'devlink_resource_validate_children' was not declared. Should it be static?
>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-01-19 19:52 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-01-17 3:27 [PATCH net-next] devlink: Make some functions static Wei Yongjun
2018-01-17 15:32 ` Jiri Pirko
2018-01-19 19:52 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).