netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: talgi@mellanox.com
Cc: netdev@vger.kernel.org, tariqt@mellanox.com,
	andrew.gospodarek@broadcom.com, saeedm@mellanox.com,
	talatb@mellanox.com
Subject: Re: [PATCH net-next] net/dim: Fix fixpoint divide exception in net_dim_stats_compare
Date: Fri, 19 Jan 2018 14:54:02 -0500 (EST)	[thread overview]
Message-ID: <20180119.145402.1348645331747765089.davem@davemloft.net> (raw)
In-Reply-To: <1516223596-11684-1-git-send-email-talgi@mellanox.com>

From: Tal Gilboa <talgi@mellanox.com>
Date: Wed, 17 Jan 2018 23:13:16 +0200

> From: Talat Batheesh <talatb@mellanox.com>
> 
> Helmut reported a bug about devision by zero while
> running traffic and doing physical cable pull test.
> 
> When the cable unplugged the ppms become zero, so when
> dividing the current ppms by the previous ppms in the
> next dim iteration there is devision by zero.
> 
> This patch prevent this division for both ppms and epms.
> 
> Fixes: c3164d2fc48f ("net/mlx5e: Added BW check for DIM decision mechanism")
> Fixes: 4c4dbb4a7363 ("net/mlx5e: Move dynamic interrupt coalescing code to include/linux")
> Reported-by: Helmut Grauer <helmut.grauer@de.ibm.com>
> Signed-off-by: Talat Batheesh <talatb@mellanox.com>
> Signed-off-by: Tal Gilboa <talgi@mellanox.com>

Applied, thanks.

      reply	other threads:[~2018-01-19 19:54 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-17 21:13 [PATCH net-next] net/dim: Fix fixpoint divide exception in net_dim_stats_compare Tal Gilboa
2018-01-19 19:54 ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180119.145402.1348645331747765089.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=andrew.gospodarek@broadcom.com \
    --cc=netdev@vger.kernel.org \
    --cc=saeedm@mellanox.com \
    --cc=talatb@mellanox.com \
    --cc=talgi@mellanox.com \
    --cc=tariqt@mellanox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).