From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net-next] net/dim: Fix fixpoint divide exception in net_dim_stats_compare Date: Fri, 19 Jan 2018 14:54:02 -0500 (EST) Message-ID: <20180119.145402.1348645331747765089.davem@davemloft.net> References: <1516223596-11684-1-git-send-email-talgi@mellanox.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, tariqt@mellanox.com, andrew.gospodarek@broadcom.com, saeedm@mellanox.com, talatb@mellanox.com To: talgi@mellanox.com Return-path: Received: from shards.monkeyblade.net ([184.105.139.130]:46232 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755940AbeASTyF (ORCPT ); Fri, 19 Jan 2018 14:54:05 -0500 In-Reply-To: <1516223596-11684-1-git-send-email-talgi@mellanox.com> Sender: netdev-owner@vger.kernel.org List-ID: From: Tal Gilboa Date: Wed, 17 Jan 2018 23:13:16 +0200 > From: Talat Batheesh > > Helmut reported a bug about devision by zero while > running traffic and doing physical cable pull test. > > When the cable unplugged the ppms become zero, so when > dividing the current ppms by the previous ppms in the > next dim iteration there is devision by zero. > > This patch prevent this division for both ppms and epms. > > Fixes: c3164d2fc48f ("net/mlx5e: Added BW check for DIM decision mechanism") > Fixes: 4c4dbb4a7363 ("net/mlx5e: Move dynamic interrupt coalescing code to include/linux") > Reported-by: Helmut Grauer > Signed-off-by: Talat Batheesh > Signed-off-by: Tal Gilboa Applied, thanks.