From: David Miller <davem@davemloft.net>
To: lorenzo.bianconi@redhat.com
Cc: netdev@vger.kernel.org, jchapman@katalix.com, g.nault@alphalink.fr
Subject: Re: [PATCH net-next] l2tp: remove switch block in l2tp_nl_cmd_session_create()
Date: Fri, 19 Jan 2018 15:10:44 -0500 (EST) [thread overview]
Message-ID: <20180119.151044.1539358362529859793.davem@davemloft.net> (raw)
In-Reply-To: <b92ac97badc4955809732f3427bf0770c08ccdd1.1516185135.git.lorenzo.bianconi@redhat.com>
From: Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
Date: Wed, 17 Jan 2018 11:41:20 +0100
> Remove the switch block in l2tp_nl_cmd_session_create() that
> checks pseudowire-specific parameters since just L2TP_PWTYPE_ETH and
> L2TP_PWTYPE_PPP are currently supported and no actual checks are
> performed. Moreover the L2TP_PWTYPE_IP/default case presents a harmless
> issue in error handling (break instead of goto out_tunnel)
>
> Signed-off-by: Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
Applied, thanks.
prev parent reply other threads:[~2018-01-19 20:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1516185135.git.lorenzo.bianconi@redhat.com>
2018-01-17 10:41 ` [PATCH net-next] l2tp: remove switch block in l2tp_nl_cmd_session_create() Lorenzo Bianconi
2018-01-17 11:32 ` Guillaume Nault
2018-01-19 20:10 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180119.151044.1539358362529859793.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=g.nault@alphalink.fr \
--cc=jchapman@katalix.com \
--cc=lorenzo.bianconi@redhat.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).