From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net-next] l2tp: remove switch block in l2tp_nl_cmd_session_create() Date: Fri, 19 Jan 2018 15:10:44 -0500 (EST) Message-ID: <20180119.151044.1539358362529859793.davem@davemloft.net> References: Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, jchapman@katalix.com, g.nault@alphalink.fr To: lorenzo.bianconi@redhat.com Return-path: Received: from shards.monkeyblade.net ([184.105.139.130]:46452 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756216AbeASUKq (ORCPT ); Fri, 19 Jan 2018 15:10:46 -0500 In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: From: Lorenzo Bianconi Date: Wed, 17 Jan 2018 11:41:20 +0100 > Remove the switch block in l2tp_nl_cmd_session_create() that > checks pseudowire-specific parameters since just L2TP_PWTYPE_ETH and > L2TP_PWTYPE_PPP are currently supported and no actual checks are > performed. Moreover the L2TP_PWTYPE_IP/default case presents a harmless > issue in error handling (break instead of goto out_tunnel) > > Signed-off-by: Lorenzo Bianconi Applied, thanks.