From: Daniel Borkmann <daniel@iogearbox.net>
To: ast@kernel.org
Cc: netdev@vger.kernel.org, Daniel Borkmann <daniel@iogearbox.net>
Subject: [PATCH bpf-next 8/9] bpf: add upper complexity limit to verifier log
Date: Sat, 20 Jan 2018 01:24:36 +0100 [thread overview]
Message-ID: <20180120002437.3528-9-daniel@iogearbox.net> (raw)
In-Reply-To: <20180120002437.3528-1-daniel@iogearbox.net>
Given the limit could potentially get further adjustments in the
future, add it to the log so it becomes obvious what the current
limit is w/o having to check the source first. This may also be
helpful for debugging complexity related issues on kernels that
backport from upstream.
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Acked-by: Alexei Starovoitov <ast@kernel.org>
---
kernel/bpf/verifier.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/kernel/bpf/verifier.c b/kernel/bpf/verifier.c
index 5eeb200..caae495 100644
--- a/kernel/bpf/verifier.c
+++ b/kernel/bpf/verifier.c
@@ -4810,7 +4810,8 @@ static int do_check(struct bpf_verifier_env *env)
insn_idx++;
}
- verbose(env, "processed %d insns, stack depth ", insn_processed);
+ verbose(env, "processed %d insns (limit %d), stack depth ",
+ insn_processed, BPF_COMPLEXITY_LIMIT_INSNS);
for (i = 0; i < env->subprog_cnt + 1; i++) {
u32 depth = env->subprog_stack_depth[i];
--
2.9.5
next prev parent reply other threads:[~2018-01-20 0:24 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-20 0:24 [PATCH bpf-next 0/9] BPF misc improvements Daniel Borkmann
2018-01-20 0:24 ` [PATCH bpf-next 1/9] bpf, verifier: detect misconfigured mem,size argument pair Daniel Borkmann
2018-01-20 0:24 ` [PATCH bpf-next 2/9] bpf: add csum_diff helper to xdp as well Daniel Borkmann
2018-01-20 0:24 ` [PATCH bpf-next 3/9] bpf: add couple of test cases for signed extended imms Daniel Borkmann
2018-01-20 0:24 ` [PATCH bpf-next 4/9] bpf: add couple of test cases for div/mod by zero Daniel Borkmann
2018-01-20 0:24 ` [PATCH bpf-next 5/9] bpf: get rid of pure_initcall dependency to enable jits Daniel Borkmann
2018-01-20 0:24 ` [PATCH bpf-next 6/9] bpf: restrict access to core bpf sysctls Daniel Borkmann
2018-01-20 0:24 ` [PATCH bpf-next 7/9] bpf, x86: small optimization in alu ops with imm Daniel Borkmann
2018-01-20 0:24 ` Daniel Borkmann [this message]
2018-01-20 0:24 ` [PATCH bpf-next 9/9] bpf: move event_output to const_size_or_zero for xdp/skb as well Daniel Borkmann
2018-01-20 2:54 ` [PATCH bpf-next 0/9] BPF misc improvements Alexei Starovoitov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180120002437.3528-9-daniel@iogearbox.net \
--to=daniel@iogearbox.net \
--cc=ast@kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).