From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jakub Kicinski Subject: [PATCH net-next v4 6/8] net: sched: create tc_can_offload_extack() wrapper Date: Fri, 19 Jan 2018 17:44:48 -0800 Message-ID: <20180120014450.29666-7-jakub.kicinski@netronome.com> References: <20180120014450.29666-1-jakub.kicinski@netronome.com> Cc: jiri@resnulli.us, aring@mojatatu.com, daniel@iogearbox.net, alexei.starovoitov@gmail.com, netdev@vger.kernel.org, oss-drivers@netronome.com, Quentin Monnet To: davem@davemloft.net, dsahern@gmail.com Return-path: Received: from mail-pg0-f67.google.com ([74.125.83.67]:40305 "EHLO mail-pg0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756278AbeATBpa (ORCPT ); Fri, 19 Jan 2018 20:45:30 -0500 Received: by mail-pg0-f67.google.com with SMTP id g16so2708669pgn.7 for ; Fri, 19 Jan 2018 17:45:30 -0800 (PST) In-Reply-To: <20180120014450.29666-1-jakub.kicinski@netronome.com> Sender: netdev-owner@vger.kernel.org List-ID: From: Quentin Monnet Create a wrapper around tc_can_offload() that takes an additional extack pointer argument in order to output an error message if TC offload is disabled on the device. In this way, the error message is handled by the core and can be the same for all drivers. Signed-off-by: Quentin Monnet Reviewed-by: Jakub Kicinski --- include/net/pkt_cls.h | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/include/net/pkt_cls.h b/include/net/pkt_cls.h index f497f622580b..2f8f16a4d88e 100644 --- a/include/net/pkt_cls.h +++ b/include/net/pkt_cls.h @@ -656,6 +656,17 @@ static inline bool tc_can_offload(const struct net_device *dev) return dev->features & NETIF_F_HW_TC; } +static inline bool tc_can_offload_extack(const struct net_device *dev, + struct netlink_ext_ack *extack) +{ + bool can = tc_can_offload(dev); + + if (!can) + NL_SET_ERR_MSG(extack, "TC offload is disabled on net device"); + + return can; +} + static inline bool tc_skip_hw(u32 flags) { return (flags & TCA_CLS_FLAGS_SKIP_HW) ? true : false; -- 2.15.1