From mboxrd@z Thu Jan 1 00:00:00 1970 From: Richard Cochran Subject: Re: [RFC v2 net-next 01/10] net: Add a new socket option for a future transmit time. Date: Fri, 19 Jan 2018 18:09:15 -0800 Message-ID: <20180120020915.erlylrbsaejf7ufo@localhost> References: <20180117230621.26074-1-jesus.sanchez-palencia@intel.com> <20180117230621.26074-2-jesus.sanchez-palencia@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Jesus Sanchez-Palencia , Network Development , Jamal Hadi Salim , Cong Wang , =?utf-8?B?SmnFmcOtIFDDrXJrbw==?= , vinicius.gomes@intel.com, intel-wired-lan@lists.osuosl.org, anna-maria@linutronix.de, henrik@austad.us, Thomas Gleixner , John Stultz , andre.guedes@intel.com, ivan.briano@intel.com, levi.pearson@harman.com, Richard Cochran To: Willem de Bruijn Return-path: Received: from mail-pg0-f68.google.com ([74.125.83.68]:45871 "EHLO mail-pg0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755643AbeATCJS (ORCPT ); Fri, 19 Jan 2018 21:09:18 -0500 Received: by mail-pg0-f68.google.com with SMTP id c194so2735739pga.12 for ; Fri, 19 Jan 2018 18:09:18 -0800 (PST) Content-Disposition: inline In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: On Fri, Jan 19, 2018 at 04:15:46PM -0500, Willem de Bruijn wrote: > > + if (cmsg->cmsg_len != CMSG_LEN(sizeof(ktime_t))) > > + return -EINVAL; > > I don't see any existing reference to ktime_t in include/uapi. Just use a s64? Agreed. I didn't see the point of switching to ktime, either. Thanks, Richard